Last Comment Bug 719319 - unnecessary to use additional OS_LIBS for firefox.exe
: unnecessary to use additional OS_LIBS for firefox.exe
Status: RESOLVED FIXED
[inbound]
:
Product: Firefox
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All Windows Vista
: -- normal (vote)
: Firefox 12
Assigned To: Makoto Kato [:m_kato] (PTO 9/22-9/25)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-18 20:02 PST by Makoto Kato [:m_kato] (PTO 9/22-9/25)
Modified: 2012-01-31 08:50 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (727 bytes, patch)
2012-01-18 20:03 PST, Makoto Kato [:m_kato] (PTO 9/22-9/25)
no flags Details | Diff | Splinter Review
fix v1.1 (1.43 KB, patch)
2012-01-19 03:14 PST, Makoto Kato [:m_kato] (PTO 9/22-9/25)
khuey: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] (PTO 9/22-9/25) 2012-01-18 20:02:39 PST
We have moved to libxul, so it is unnecessary to use additional OS_LIBS into browser/app/Makefile.
Comment 1 Makoto Kato [:m_kato] (PTO 9/22-9/25) 2012-01-18 20:03:46 PST
Created attachment 589764 [details] [diff] [review]
fix
Comment 2 Makoto Kato [:m_kato] (PTO 9/22-9/25) 2012-01-19 03:14:28 PST
Created attachment 589820 [details] [diff] [review]
fix v1.1
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2012-01-30 03:12:27 PST
Comment on attachment 589820 [details] [diff] [review]
fix v1.1

Review of attachment 589820 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming this builds fine, r=me.
Comment 4 Makoto Kato [:m_kato] (PTO 9/22-9/25) 2012-01-31 02:32:59 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0256a2b3986
Comment 5 Ed Morley [:emorley] 2012-01-31 08:50:49 PST
https://hg.mozilla.org/mozilla-central/rev/c0256a2b3986

Note You need to log in before you can comment on or make changes to this bug.