TorButton causes memory leaks/growth

RESOLVED WORKSFORME

Status

()

Firefox
Extension Compatibility
RESOLVED WORKSFORME
6 years ago
6 years ago

People

(Reporter: jesup, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P3], URL)

(Reporter)

Description

6 years ago
From bug 490122:

randall@dasaku.net (New to Bugzilla) 2012-01-18 18:42:25 PST

I did an exhaustive run through of my add-ons after launching in Safe-Mode determined that it was an add-on based problem for me.

After disabling everything, it came to it that TorButton was the add-on that was causing the problem, so I'd say if you're running TorButton and launching firefox in safe-mode fixes the issue, start by disabling TorButton just to give it a shot.
https://www.torproject.org/torbutton/ is the URL.  It says:

"Now that the Tor Browser Bundle includes a patched version of Firefox, and because we don't have enough developer resources to keep up with the accelerated Firefox release schedule, the toggle model of Torbutton is no longer recommended. Users should be using Tor Browser Bundle, not installing Torbutton themselves."

The Tor Browser Bundle is a custom version of Firefox, presumably an oldish one, with the extension installed.  It's at https://www.torproject.org/projects/torbrowser.html.en.  Weird.
Also, TorButton isn't available on AMO, so we can't do anything about it via that route.
What's sad about this is that they're encouraging people to use an *insecure* version of Firefox.  For Tor, the most paranoid of Web services!
Whiteboard: [MemShrink] → [MemShrink:P3]
I e-mailed the tor-assistants list.

It looks like Tor Browser is currently Aurora 9.0.1.  :(

Comment 5

6 years ago
It looks like Mozilla's naming/name trademark policy is confusing even for the Mozilla folk. Firefox 9.0.1 when build without the Firefox branding calls itself Aurora, and we cannot call it Firefox due to the modifications we need to make. Please try to confirm asap whether there actually is an older version shipped, before making such claims.
> Please try to confirm asap whether there actually is an older version shipped, before making such 
> claims.

I'm sorry for the confusion.

I think you can rename the binary by setting MOZ_APP_DISPLAYNAME in your .mozconfig.  You can't call it "Firefox", but you could call it "Tor Browser".
I haven't been able to reproduce this leak, either with TorBrowser or in Nightly with Tor Button (installed but with Tor disabled).  I browsed around to maybe 10 sites and didn't see abnormal memory growth or zombie compartments.

John, do you have a rough set of steps to reproduce?
Closing as WFM per comment 7.  Please re-open if you have STR.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.