When the URLs are very long (style editor), the user needs to resize to see the editor.

VERIFIED FIXED in Firefox 11

Status

defect
VERIFIED FIXED
8 years ago
Last year

People

(Reporter: davidb, Assigned: paul)

Tracking

unspecified
Firefox 12
x86
macOS

Firefox Tracking Flags

(firefox11- verified, firefox12 verified)

Details

(Whiteboard: [qa!])

Attachments

(1 attachment)

Ping me if you need STR.
Assignee

Comment 1

8 years ago
Posted patch patch v1Splinter Review
Assignee

Updated

8 years ago
Attachment #590743 - Flags: review?(jwalker)
Comment on attachment 590743 [details] [diff] [review]
patch v1

Review of attachment 590743 [details] [diff] [review]:
-----------------------------------------------------------------

400px feels arbitrary. Is there no better way?
Attachment #590743 - Flags: review?(jwalker) → review+
Assignee

Comment 3

8 years ago
(In reply to Joe Walker from comment #2)
> Comment on attachment 590743 [details] [diff] [review]
> patch v1
> 
> Review of attachment 590743 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> 400px feels arbitrary. Is there no better way?

It is half of the original size: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/styleeditor/styleeditor.xul#53
(In reply to Paul Rouget [:paul] from comment #3)
> (In reply to Joe Walker from comment #2)
> > Comment on attachment 590743 [details] [diff] [review]
> > patch v1
> > 
> > Review of attachment 590743 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > 400px feels arbitrary. Is there no better way?
> 
> It is half of the original size:
> http://mxr.mozilla.org/mozilla-central/source/browser/devtools/styleeditor/
> styleeditor.xul#53

I was wondering if there wasn't a better solution than using an absolute value, but I realize that it can be hard.
Assignee

Updated

8 years ago
Whiteboard: [land-in-fx-team]
Assignee

Updated

8 years ago
Assignee: nobody → paul
Assignee

Updated

8 years ago
Assignee

Comment 5

8 years ago
https://hg.mozilla.org/integration/fx-team/rev/c34ef990df33
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Assignee

Comment 6

8 years ago
I will a? this patch once in central.
Whiteboard: [fixed-in-fx-team] → [fixed-in-fx-team][addToFirefox11]
https://hg.mozilla.org/mozilla-central/rev/c34ef990df33
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][addToFirefox11] → [addToFirefox11]
Target Milestone: --- → Firefox 12
Comment on attachment 590743 [details] [diff] [review]
patch v1

[Approval Request Comment]
Regression caused by (bug #): New Feature. Not a regression.
User impact if declined: User will have to resize to see the editor.
Testing completed (on m-c, etc.): on m-c, local testing.
Risk to taking this patch (and alternatives if risky): Negligble. Styling only.
Attachment #590743 - Flags: approval-mozilla-aurora?
Comment on attachment 590743 [details] [diff] [review]
patch v1

[Triage Comment]
Regression in new feature, approved for Aurora.
Attachment #590743 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [qa+]
Verified using Firefox 11 beta 3 on Windows 7, Ubuntu 11.10 and Mac OS X 10.6.

Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0

The user does not need to resize the editor in order to see it, the URL's can not be dragged wider than 400px.
Whiteboard: [qa+] → [qa+][qa!:11]
Verified as fixed on Firefox 12 beta 2 - the user does not need to resize the editor in order to see it, the URL's can not be dragged wider than 400px.

Verified on Windows 7, Ubuntu 11.10 and Mac OS X 10.6.
Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20100101 Firefox/12.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0

Setting resolution to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+][qa!:11] → [qa!]

Comment 13

6 years ago
On Firefox 26 long filenames seem to be displayed in full again. e.g. I have one that is 1214px wide

Comment 14

6 years ago
Sorry, this is on the PC version. Should I open a different bug?

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.