719538 - use nsIWindowsRegKey in Windows shell service

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

...instead of calling the registry APIs directly

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 589939 [details] [diff] [review]
patch

Review of attachment 589939 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/shell/src/nsWindowsShellService.cpp
@@ +785,5 @@
> +                      nsIWindowsRegKey::ACCESS_SET_VALUE);
> +  NS_ENSURE_SUCCESS(rv, rv);
> +
> +  char rgb[12];
> +  sprintf((char*)rgb, "%u %u %u\0", r, g, b);

Couldn't we print this into a PRUnichar buf and skip the use of NS_ConvertUTF8toUTF16 all together?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

please double check my _snwprintfing!

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 589977 [details] [diff] [review]
patch

look ok to me!

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb09304af438

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/eb09304af438