Closed Bug 719538 Opened 8 years ago Closed 8 years ago

use nsIWindowsRegKey in Windows shell service

Categories

(Firefox :: Shell Integration, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 12

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file, 1 obsolete file)

...instead of calling the registry APIs directly
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #589939 - Flags: review?(jmathies)
Blocks: 662324
Comment on attachment 589939 [details] [diff] [review]
patch

Review of attachment 589939 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/shell/src/nsWindowsShellService.cpp
@@ +785,5 @@
> +                      nsIWindowsRegKey::ACCESS_SET_VALUE);
> +  NS_ENSURE_SUCCESS(rv, rv);
> +
> +  char rgb[12];
> +  sprintf((char*)rgb, "%u %u %u\0", r, g, b);

Couldn't we print this into a PRUnichar buf and skip the use of NS_ConvertUTF8toUTF16 all together?
Attachment #589939 - Flags: review?(jmathies) → review+
Attached patch patchSplinter Review
please double check my _snwprintfing!
Attachment #589977 - Flags: review?(jmathies)
Comment on attachment 589977 [details] [diff] [review]
patch

look ok to me!
Attachment #589977 - Flags: review?(jmathies) → review+
Attachment #589939 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/eb09304af438
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.