719544 - Make the pine branch to allow downloading talos.zip from any place like on "try"

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

Attachment: exception for pine plus some clean up

jmaher gave me r+ on IRC but I will wait until he lands a talos.json on pine so I can test it before landing it.

Comment 1

[Armen [:armenzg]]

Comment on attachment 589949 [details] [diff] [review]
exception for pine plus some clean up

I tested that my changes work.
This is live now.

Armens-MacBook-Air:tools armenzg$ python scripts/talos/talos_from_code.py --talos-json-url http://hg.mozilla.org/projects/pine/raw-file/default/testing/talos/talos.json
ERROR: We have been unable to download the talos.zip indicated in the talos.json file.
ERROR: HTTP Error 404: Not Found
Armens-MacBook-Air:tools armenzg$ python scripts/talos/talos_from_code.py --talos-json-url http://hg.mozilla.org/projects/pine/raw-file/default/testing/talos/talos.json
INFO: talos.json URL:  http://hg.mozilla.org/projects/pine/raw-file/default/testing/talos/talos.json
INFO: talos.zip URL: 'http://build.mozilla.org/talos/zips/talos.bug718795.d93f2b21985c.zip'
Armens-MacBook-Air:tools armenzg$ hg ci -m "Bug 719544 - Make the pine branch to allow downloading talos.zip from any place like on 'try'. r=jmaher"
Armens-MacBook-Air:tools armenzg$ hg pull -u
pulling from http://hg.mozilla.org/build/tools
searching for changes
no changes found
Armens-MacBook-Air:tools armenzg$ hg push
pushing to ssh://hg.mozilla.org/build/tools
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
remote: Trying to insert into pushlog.
remote: Please do not interrupt...
remote: Inserted into the pushlog db successfully.

Comment 2

[Armen [:armenzg]]

pine should be like try wrt to talos.json.

Comment 3

[Armen [:armenzg]]

Attachment: really allow the pine tree to behave the same way as try

It seems the == False and == False condition was wrong.
This change should do.

Armens-MacBook-Air:tools armenzg$ python scripts/talos/talos_from_code.py --talos-json-url http://people.mozilla.com/~armenzg/talos/talos2.json
INFO: talos.json URL:  http://people.mozilla.com/~armenzg/talos/talos2.json
INFO: talos.zip URL: 'http://people.mozilla.org/~jmaher/taloszips/tip/zips/talos.pine.zip'
ERROR: You have tried to download a talos.zip from a location different than http://build.mozilla.org/talos/zips
ERROR: This is only allowed for the 'try' branch.
Armens-MacBook-Air:tools armenzg$ python scripts/talos/talos_from_code.py --talos-json-url http://hg.mozilla.org/projects/pine/raw-file/67962f8c1fdf/testing/talos/talos.json
INFO: talos.json URL:  http://hg.mozilla.org/projects/pine/raw-file/67962f8c1fdf/testing/talos/talos.json
INFO: talos.zip URL: 'http://people.mozilla.org/~jmaher/taloszips/tip/zips/talos.pine.zip'
Armens-MacBook-Air:tools armenzg$ python scripts/talos/talos_from_code.py --talos-json-url http://hg.mozilla.org/try/raw-file/9733dcdaad08/testing/talos/talos.json
INFO: talos.json URL:  http://hg.mozilla.org/try/raw-file/9733dcdaad08/testing/talos/talos.json
INFO: talos.zip URL: 'http://build.mozilla.org/talos/zips/talos.bug719946.49138575dae9.zip'
Armens-MacBook-Air:tools armenzg$ python scripts/talos/talos_from_code.py --talos-json-url http://people.mozilla.com/~armenzg/talos/talos.json
INFO: talos.json URL:  http://people.mozilla.com/~armenzg/talos/talos.json
INFO: talos.zip URL: 'http://build.mozilla.org/talos/zips/talos.zip'

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 592118 [details] [diff] [review]
really allow the pine tree to behave the same way as try

Review of attachment 592118 [details] [diff] [review]:
-----------------------------------------------------------------

please fix my comment below.

::: scripts/talos/talos_from_code.py
@@ +41,3 @@
>      try:
> +        #download_file(talos_zip_url, "talos.zip")
> +        pass

we have a
try:
  pass
except:


clause here, can we move the if inside the try or remove the try/except block?

Comment 5

[Armen [:armenzg]]

Comment on attachment 592118 [details] [diff] [review]
really allow the pine tree to behave the same way as try

I put the if inside of the try block. The 'pass' was introduced in the patch by mistake for local testing.

http://hg.mozilla.org/build/tools/rev/f2db082a57e9