Last Comment Bug 719575 - gfx broke my clang builds
: gfx broke my clang builds
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla12
Assigned To: :Ehsan Akhgari
:
:
Mentors:
Depends on:
Blocks: clang
  Show dependency treegraph
 
Reported: 2012-01-19 13:25 PST by :Ehsan Akhgari
Modified: 2012-01-21 07:12 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1.45 KB, patch)
2012-01-19 13:26 PST, :Ehsan Akhgari
matt.woodrow: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2012-01-19 13:25:19 PST
/Users/ehsanakhgari/moz/oak/gfx/skia/src/effects/SkGradientShader.cpp:1998:17: warning: unused function 'atan_0_90' [-Wunused-function]
static unsigned atan_0_90(SkFixed y, SkFixed x) {
                ^
1 warning generated.
/Users/ehsanakhgari/moz/oak/gfx/skia/src/ports/SkFontHost_mac_coretext.cpp:799:28: error: non-constant-expression cannot be narrowed from type 'CGFloat' (aka 'double') to 'SkScalar' (aka 'float') in initializer list
    const SkPoint trans = {SkFloatToScalar(vertOffset.width),
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/oak/gfx/skia/include/core/SkScalar.h:111:37: note: expanded from:
    #define SkFloatToScalar(n)      (n)
                                    ^~~
/Users/ehsanakhgari/moz/oak/gfx/skia/src/ports/SkFontHost_mac_coretext.cpp:799:28: note: override this message by inserting an explicit cast
    const SkPoint trans = {SkFloatToScalar(vertOffset.width),
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/oak/gfx/skia/include/core/SkScalar.h:111:37: note: expanded from:
    #define SkFloatToScalar(n)      (n)
                                    ^~~
/Users/ehsanakhgari/moz/oak/gfx/skia/src/ports/SkFontHost_mac_coretext.cpp:800:28: error: non-constant-expression cannot be narrowed from type 'CGFloat' (aka 'double') to 'SkScalar' (aka 'float') in initializer list
                           SkFloatToScalar(vertOffset.height)};
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/oak/gfx/skia/include/core/SkScalar.h:111:37: note: expanded from:
    #define SkFloatToScalar(n)      (n)
                                    ^~~
/Users/ehsanakhgari/moz/oak/gfx/skia/src/ports/SkFontHost_mac_coretext.cpp:800:28: note: override this message by inserting an explicit cast
                           SkFloatToScalar(vertOffset.height)};
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/ehsanakhgari/moz/oak/gfx/skia/include/core/SkScalar.h:111:37: note: expanded from:
    #define SkFloatToScalar(n)      (n)
                                    ^~~
2 errors generated.
Comment 1 :Ehsan Akhgari 2012-01-19 13:26:32 PST
Created attachment 589973 [details] [diff] [review]
Patch (v1)
Comment 3 Ed Morley [:emorley] 2012-01-21 07:12:02 PST
https://hg.mozilla.org/mozilla-central/rev/26998c1affd1

Note You need to log in before you can comment on or make changes to this bug.