71974 - [FLOAT]{inc}Load of floating image doesn't cause enough reflow

Status: RESOLVED WORKSFORME

(Core :: Layout: Floats, defect, P3)

Description

[Miloslaw Smyk]

At http://www.kinoman.pl/film.asp?id=637 (and basically any other movie page at
this site), description text in the gray box overwrites image on the right side.

Tested with 0.8 and with "Mozilla/5.0 (X11; U; Linux 2.4.2 i686; en-US; 0.8.1)
Gecko/20010311" - same behavior.

Repeatable: always

Expected behavior: I think it's obvious.

Comment 1

[Oliver Klee]

This sounds like a dupe of some other layout bug.

Comment 2

[Keyser Sose]

*** This bug has been marked as a duplicate of 55917 ***

Comment 3

[Miloslaw Smyk]

Bug #55917 has been marked RESOLVED INVALID, but this one is still not fixed.
Reopening.

Comment 4

[Miloslaw Smyk]

...and confirming it, too.

I'm running Linux/i686 2001073021 these days.

Comment 5

[Marc Attinasi]

Attachment: Reduced testcase: floated image wrapped in a heading is not causing the paragraph to reflow when the image comes in

Comment 6

[Marc Attinasi]

I attached a testcase, but I see now that you may have to reload the testcase
after you navigate to it to see the problem. Or, save it locally and you will
see the problem. If the image size somes in soon enough then the text will flow
around it OK, but if the image comes in too late, then the text around it is not
relowed.

CC'ing dbaron because I think he fixed a slew of these problems recently 

Comment 7

[Marc Attinasi]

Block problem, no tables involved.

Comment 8

[Christian Reis]

*** Bug 90955 has been marked as a duplicate of this bug. ***

Comment 9

[Christian Reis]

*** Bug 71282 has been marked as a duplicate of this bug. ***

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The basic way we decide what to invalidate when a float changes is seriously
broken -- see the comments I added to the code in my patch on bug 86947 (in
RememberReflowDamage and PropogateReflowDamage).  I am not attempting to fix it
in that patch, which is large enough already.

Comment 11

[rubydoo123]

I don't quite understand the correlation between the reflow and setting the 
image width, but if I specify the width of the image it works perfectly. 
Shouldn't we be implicitly defining the width and height of the image?

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes, but not until we've actually loaded the image.  This means when the image
loads we have an incremental reflow.  This is an incremental reflow bug.

Comment 13

[Marc Attinasi]

*** Bug 52265 has been marked as a duplicate of this bug. ***

Comment 14

[Markus Hübner]

could bug 98001 be related to this one (incremental reflow bug)?

Comment 15

[Marc Attinasi]

Moving out to 0.9.9 - 0.9.8 overloaded for me :(

Comment 16

[Marc Attinasi]

[FLOAT] bugs to Alex :)

Comment 17

[Alexandru Savulov]

retargeting

Comment 18

[rubydoo123]

removing myself from the cc list

Comment 19

[Miloslaw Smyk]

WFM 2002060704, Linux-i686

Comment 20

[junk]

Is this a good example of this bug? I have set the height and width in the css,
but when the page loads slowly, the floated image screws up. Should be in
the top left corner. Works fine if page loads fast, or offline. Really, really
annoying. 

http://scootrs.com/moz/floatbug.jpg

Anyone know a workaround? Or is the code wrong?

http://cgi.ebay.com/ebaymotors/ws/eBayISAPI.dll?ViewItem&item=1836895480

Comment 21

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Moving to floats.  We need to check all the duplicates here before marking as
worksforme or duplicate...

Comment 22

[Sterling Bates]

Testcase and dupes check out (bug 52265, bug 71282 and bug 90955) on WinXP build
20030421.

Comment 23

[Vedran Miletic]

retargeting

Comment 24

[Mats Palmgren (inactive)]

WFM, all URLs and testcases. Mozilla 2004-12-01-06 trunk Linux.

Comment 25

[Jamie Diamond]

Worksforme on nightly 
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050405 Firefox/1.0+
with 10.3.8 mac.

Comment 26

[Carsten Book [:Tomcat]]

WFM Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b2) Gecko/20050405 all
links.

Comment 27

[Robin Monks]

Also WFM on Firefox 1.0.2 on Windows XP SP2 (Also worked for other bugday
testers).  Marking a WFM.