Last Comment Bug 719845 - [markup panel] The HTML Tree should have its own keybindings
: [markup panel] The HTML Tree should have its own keybindings
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Inspector (show other bugs)
: Trunk
: x86 All
: P3 normal (vote)
: Firefox 16
Assigned To: Nobody; OK to take it and work on it
:
:
Mentors:
: 754661 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-20 08:27 PST by Paul Rouget [:paul]
Modified: 2012-07-10 02:07 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
WIP (8.45 KB, patch)
2012-06-01 21:39 PDT, Dave Camp (:dcamp)
no flags Details | Diff | Splinter Review
v1 (18.38 KB, patch)
2012-07-04 08:00 PDT, Paul Rouget [:paul]
dcamp: review+
Details | Diff | Splinter Review

Description Paul Rouget [:paul] 2012-01-20 08:27:22 PST
The keybindings in the inspector map the layout of the Breadcrumbs (left for parent node for example). The HTML Tree has a different layout, and some keybindings don't make sense.

Up and Down should select the next line in the tree. Even if the line is a closing tag.
Left and Right should Close and Open the current Node.
Comment 1 Paul Rouget [:paul] 2012-05-14 01:38:39 PDT
*** Bug 754661 has been marked as a duplicate of this bug. ***
Comment 2 Rob Campbell [:rc] (:robcee) 2012-05-14 13:44:05 PDT
(In reply to Paul Rouget [:paul] from bug 754661 comment #4)
> iirc, we had to disable the shortcut because they were messing with the
> other highlighter shortcuts, and they were confusing (up and down to visit
> the parent and descendants, right and left to visit the siblings).

Not confusing for users of Firebug. I think it's fairly standard tree-view navigation for left/right to close and open tree-items and up down to navigate. Maybe that's made confusing because of the breadcrumb navigation keys.
Comment 3 Paul Rouget [:paul] 2012-05-15 01:47:54 PDT
(In reply to Rob Campbell [:rc] (:robcee) from comment #2)
> (In reply to Paul Rouget [:paul] from bug 754661 comment #4)
> > iirc, we had to disable the shortcut because they were messing with the
> > other highlighter shortcuts, and they were confusing (up and down to visit
> > the parent and descendants, right and left to visit the siblings).
> 
> Not confusing for users of Firebug. I think it's fairly standard tree-view
> navigation for left/right to close and open tree-items and up down to
> navigate. Maybe that's made confusing because of the breadcrumb navigation
> keys.

Yes. And we should implement this behavior. But that is not what we got in the tree view.

Before:
* up/down, visit siblings;
* right/left, visit parents/descendants.

Firebug (and what we should implement):
* up/down, visit the previous (or next) element in the tree (like a cursor);
* left/right, fold/unfold a node.

We should use these shortcuts as soon as the treeview is open (even if not focused).
Comment 4 Dave Camp (:dcamp) 2012-06-01 21:39:00 PDT
Created attachment 629436 [details] [diff] [review]
WIP

This patch implements the keybindings if the tree is focused.  But I think agree with paul, that they should be true if the html panel is open at all.

Also doesn't have tests, but I don't want to lose this patch.
Comment 5 Paul Rouget [:paul] 2012-07-04 08:00:41 PDT
Created attachment 639101 [details] [diff] [review]
v1
Comment 6 Paul Rouget [:paul] 2012-07-09 06:50:06 PDT
https://hg.mozilla.org/integration/fx-team/rev/28473532325e
Comment 7 Tim Taubert [:ttaubert] 2012-07-10 02:07:20 PDT
https://hg.mozilla.org/mozilla-central/rev/28473532325e

Note You need to log in before you can comment on or make changes to this bug.