IonMonkey: congruentTo should be opt-in rather than opt-out

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
If an instruction does not override congruentTo, it defaults to comparing the value numbers of the operands. This is error prone, see bug 719774.
(Assignee)

Comment 1

6 years ago
Created attachment 590770 [details] [diff] [review]
Patch

I don't really like the name "congruentIfEqualOperands", but I can't think of a better name, suggestions welcome.
Attachment #590770 - Flags: review?(dvander)
Attachment #590770 - Flags: review?(dvander) → review+
(congruentIfOperandsEqual reads 8% better)
(Assignee)

Comment 3

6 years ago
(In reply to David Anderson [:dvander] from comment #2)
> (congruentIfOperandsEqual reads 8% better)

Pushed with this change:

https://hg.mozilla.org/projects/ionmonkey/rev/151c3f95b870

Probably a SS win because we're now able to hoist the SETELEM bounds check (the alias set for MStoreElement was too strict).
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.