Closed
Bug 719855
Opened 12 years ago
Closed 12 years ago
IonMonkey: congruentTo should be opt-in rather than opt-out
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
26.89 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
If an instruction does not override congruentTo, it defaults to comparing the value numbers of the operands. This is error prone, see bug 719774.
Assignee | ||
Comment 1•12 years ago
|
||
I don't really like the name "congruentIfEqualOperands", but I can't think of a better name, suggestions welcome.
Attachment #590770 -
Flags: review?(dvander)
Updated•12 years ago
|
Attachment #590770 -
Flags: review?(dvander) → review+
(congruentIfOperandsEqual reads 8% better)
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to David Anderson [:dvander] from comment #2) > (congruentIfOperandsEqual reads 8% better) Pushed with this change: https://hg.mozilla.org/projects/ionmonkey/rev/151c3f95b870 Probably a SS win because we're now able to hoist the SETELEM bounds check (the alias set for MStoreElement was too strict).
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•