Last Comment Bug 719878 - AllFramesIter does not find all frames when the current segment contains only a native call
: AllFramesIter does not find all frames when the current segment contains only...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla12
Assigned To: Luke Wagner [:luke]
:
Mentors:
Depends on:
Blocks: 698580
  Show dependency treegraph
 
Reported: 2012-01-20 10:05 PST by Luke Wagner [:luke]
Modified: 2012-01-21 05:53 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.63 KB, patch)
2012-01-20 10:05 PST, Luke Wagner [:luke]
sphink: review+
Details | Diff | Splinter Review

Description Luke Wagner [:luke] 2012-01-20 10:05:20 PST
Created attachment 590237 [details] [diff] [review]
fix

It should continue on to the next segment, just like operator++.
Comment 1 Steve Fink [:sfink] [:s:] 2012-01-20 10:27:39 PST
This doesn't really truly block bug 698580, but it trips an assertion if it snarfs some non-innermost frames out of the native stack that AllFramesIter is ignorant of.
Comment 3 Ed Morley [:emorley] 2012-01-21 05:53:24 PST
https://hg.mozilla.org/mozilla-central/rev/b881c5526ed2

Note You need to log in before you can comment on or make changes to this bug.