Closed Bug 719900 Opened 8 years ago Closed 8 years ago

Remove blank favicon images from awesomebar lists

Categories

(Firefox for Android :: General, defect, P3)

11 Branch
ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 13
Tracking Status
firefox11 --- verified
firefox12 --- verified
firefox13 --- verified
fennec 11+ ---

People

(Reporter: ibarlow, Assigned: bnicholson)

Details

(Keywords: polish)

Attachments

(2 files)

Attached image mockup
Now that we've enabled Sync, we're finding ourselves with long lists of sites that are all missing favicons. The empty dotted line placeholder we are using seemed appropriate up until now, given that generally we were only missing one or two favicons in a long list, but now that we see hundreds of them in a row, it just looks unpolished.

In a perfect world, we would be getting favicons as part of the Sync transfer, but since that won't be ready for Firefox 11, we need a simpler alternative.

Let's just get rid of empty favicon images for the time being, and show nothing unless a site provides us with one. A mockup is attached.
Assignee: nobody → bnicholson
tracking-fennec: --- → 11+
Priority: -- → P3
Attached patch patchSplinter Review
Attachment #593646 - Flags: review?(mark.finkle)
Attachment #593646 - Flags: review?(mark.finkle) → review+
Comment on attachment 593646 [details] [diff] [review]
patch

[Approval Request Comment]
UI changes to AwesomeBar favicons. Low risk.
Attachment #593646 - Flags: approval-mozilla-beta?
Attachment #593646 - Flags: approval-mozilla-aurora?
Comment on attachment 593646 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.
Attachment #593646 - Flags: approval-mozilla-beta?
Attachment #593646 - Flags: approval-mozilla-beta+
Attachment #593646 - Flags: approval-mozilla-aurora?
Attachment #593646 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/23607f342e2a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
Nightly 13.0a1 (2012-02-06)
Aurora 12.0a2 (2012-02-06)
Beta 11.0 (2012-02-06): 20120206042108 - http://hg.mozilla.org/releases/mozilla-beta/rev/6a71fe8b7ada
Device: Samsung Google Nexus S - Android 2.3.6

Verified fixed.
OS: Mac OS X → Android
Hardware: x86 → ARM
You need to log in before you can comment on or make changes to this bug.