2.75 KB, patch
|Details | Diff | Splinter Review|
We need to add a new parameter to the Component sections that reflects the component's .xpi archive size. We can use the following format: [Component???] ... Archive Size=<#componentName_archiveSize> So, for example XPCOM may look like: [Component0] ... Archive Size=<#xpcom_archiveSize> The build automation will need to parse for and substitute the values of all the archive sizes. This will be used in two places in the installer: 1> when calculating required disk space before download 2> in making a unified download progress bar that will reflect the progress of all xpis being download with a singe total max summation of all their sizes.
Created attachment 28552 [details] [diff] [review] patch to config.ini_tmpl for both mozilla & netscape
fixed. checked in: mozilla/xpinstall/wizard/mac/macbuild/config.ini_tmpl ns/xpinstall/wizard/mac/config.ini_tmpl
Samir, I think you're the person who should verify this bug since the changes were made for the new progress bar model you're working on.
Archive sizes are now in both ns and moz installer config.inis. Small nit that will have an impact on download progress UI: it looks like the archive size is calculated in KB by dividing by 1000 instead of by 1024. Please change this calculation to divide by a factor of 1024. Reopening for this nit. (Thanks for getting the Archive Size key implemented expediently.)
changing QA contact to sgehani per jj's comments. jj's out til 5/1, so leaving target as 0.9.1.
The new donwload UI will be dependent on this. If the new download UI will go in for nsbeta1 (which it is currently scheduled for per bug 77979) then we need this too. Hence, nominating for good measure.
plussing since this is a required subtask of an already-plussed bug
Oops, this one slipped through the craks. Just fixed.