719916 - style inspector loses focus after entering attribute name

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Stefan]

User Agent:  

Steps to reproduce:

1. Open a new tab (blank page).
2. Inspect (ctrl-shift-i).
3. Press "Style" Button.
4. Click at closing brace ('}').
5. Enter 'foo'.
6. Press ':'-Key or RETURN-Key.


Actual results:

6. No focus in value field.


Expected results:

6. Focus in the value field.

Comment 1

[Tim (fmdeveloper)]

Confirmed on Mozilla/5.0 (Windows NT 5.1; rv:12.0a1) Gecko/20120120 Firefox/12.0a1 ID:20120120031125

Comment 2

[Paul Rouget [:paul]]

I think this happens with about:* pages (same behavior with about:home).

Comment 3

[Dave Camp (:dcamp)]

Attachment: fix

Comment 4

[Joe Walker [:jwalker]]

Comment on attachment 602945 [details] [diff] [review]
fix

Review of attachment 602945 [details] [diff] [review]:
-----------------------------------------------------------------

This may be hacky but it has 2 great features for hacky:
- It's short
- There are more lines of comment than hack

::: browser/devtools/styleinspector/CssRuleView.jsm
@@ +724,4 @@
>      }
>      this._viewedElement = null;
>      this._elementStyle = null;
> +    this._focusBackstop = null;

Way back when I was a C programmer doing manual memory management, I had a rule for getting it right - symmetry - there must be symmetry between allocation and deallocation, so I might remove the event listener before I delete the element.

(That's a 'yes I read this' comment. You probably want to ignore me :)

Comment 5

[Dave Camp (:dcamp)]

Attachment: updated per review comment

https://tbpl.mozilla.org/?tree=Try&rev=267a47771847

Comment 6

[Dave Camp (:dcamp)]

Attachment: removed broken test changes

That patch included some half-baked broken test changes in addition to the working new test.  Pulled that out, ran through try:

https://tbpl.mozilla.org/?tree=Try&rev=af755dafec46

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/cef966930777