Closed Bug 719933 Opened 9 years ago Closed 9 years ago

In the Inspector, the arrowkeys shortcuts should be used only when the higlighter or the toolbar are focused

Categories

(DevTools :: General, defect)

x86
All
defect
Not set
normal

Tracking

(firefox11-, firefox12 fixed)

RESOLVED FIXED
Firefox 12
Tracking Status
firefox11 - ---
firefox12 --- fixed

People

(Reporter: paul, Assigned: paul)

References

Details

(Whiteboard: [qa+])

Attachments

(2 files, 2 obsolete files)

No description provided.
Duplicate of this bug: 719866
Duplicate of this bug: 719834
Attached patch patch v1 (obsolete) — Splinter Review
We can't have the same event logic for the arrowkeys and the other keys. Because we don't want the arrow keys to be used when we are (focused) in the sidebar or in the HTML tree, because the keys mean something else there.

We can't move all the event in the same place because some keys are used everywhere (ESC for example).

So in this patch, I moved all the arrowkeys event logic in the breadcrumbs code because the browsing-logic should follow the current breadcrumbs layout (see bug 719834).

Only 3 elements of the UI should use the arrowkey events:
- Toolbar (not just the breadcrumbs)
- The highlighter veil
- The content window (because the highlighter veil can be key-event-unsensitive with pointer-events:none)
Well, no. I think I get that wrong.
Attachment #590309 - Attachment is obsolete: true
Attached patch patch v3 (obsolete) — Splinter Review
Attachment #590385 - Flags: review?(rcampbell)
Duplicate of this bug: 698752
Comment on attachment 590385 [details] [diff] [review]
patch v3

+  /**
+   * Remove the event listeners for the arrowkeys.
+   */
+   cleanNavigationKeys:

I might change that name to "clearNavigationKeys" or even "remove".

Presumably the existing unittests work for this?
Attachment #590385 - Flags: review?(rcampbell) → review+
Attached patch patch v3.1Splinter Review
Whiteboard: [land-in-fx-team]
Attachment #590385 - Attachment is obsolete: true
Assignee: nobody → paul
https://hg.mozilla.org/integration/fx-team/rev/01a1a9d50106
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/01a1a9d50106
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
This does not appear to be critical enough to track, although you can make your case for uplifting to Beta 11 in a nomination.
Whiteboard: [qa+]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.