In the Inspector, the arrowkeys shortcuts should be used only when the higlighter or the toolbar are focused

RESOLVED FIXED in Firefox 12

Status

defect
RESOLVED FIXED
8 years ago
Last year

People

(Reporter: paul, Assigned: paul)

Tracking

Trunk
Firefox 12
x86
All

Firefox Tracking Flags

(firefox11-, firefox12 fixed)

Details

(Whiteboard: [qa+])

Attachments

(2 attachments, 2 obsolete attachments)

Assignee

Description

8 years ago
No description provided.
Assignee

Updated

8 years ago
Duplicate of this bug: 719866
Assignee

Updated

8 years ago
Duplicate of this bug: 719834
Assignee

Comment 3

8 years ago
Posted patch patch v1 (obsolete) — Splinter Review
Assignee

Comment 4

8 years ago
We can't have the same event logic for the arrowkeys and the other keys. Because we don't want the arrow keys to be used when we are (focused) in the sidebar or in the HTML tree, because the keys mean something else there.

We can't move all the event in the same place because some keys are used everywhere (ESC for example).

So in this patch, I moved all the arrowkeys event logic in the breadcrumbs code because the browsing-logic should follow the current breadcrumbs layout (see bug 719834).

Only 3 elements of the UI should use the arrowkey events:
- Toolbar (not just the breadcrumbs)
- The highlighter veil
- The content window (because the highlighter veil can be key-event-unsensitive with pointer-events:none)
Assignee

Comment 5

8 years ago
Well, no. I think I get that wrong.
Assignee

Updated

8 years ago
Attachment #590309 - Attachment is obsolete: true
Assignee

Comment 6

8 years ago
Posted patch patch v3 (obsolete) — Splinter Review
Assignee

Updated

8 years ago
Attachment #590385 - Flags: review?(rcampbell)
Assignee

Updated

8 years ago
Duplicate of this bug: 698752
Comment on attachment 590385 [details] [diff] [review]
patch v3

+  /**
+   * Remove the event listeners for the arrowkeys.
+   */
+   cleanNavigationKeys:

I might change that name to "clearNavigationKeys" or even "remove".

Presumably the existing unittests work for this?
Attachment #590385 - Flags: review?(rcampbell) → review+
Assignee

Comment 9

8 years ago
Posted patch patch v3.1Splinter Review
Assignee

Updated

8 years ago
Whiteboard: [land-in-fx-team]
Assignee

Updated

8 years ago
Attachment #590385 - Attachment is obsolete: true
Assignee

Updated

8 years ago
Assignee: nobody → paul
Assignee

Updated

8 years ago
Assignee

Comment 10

8 years ago
Assignee

Comment 11

8 years ago
https://hg.mozilla.org/integration/fx-team/rev/01a1a9d50106
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/01a1a9d50106
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
This does not appear to be critical enough to track, although you can make your case for uplifting to Beta 11 in a nomination.
Whiteboard: [qa+]

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.