Closed
Bug 719933
Opened 13 years ago
Closed 13 years ago
In the Inspector, the arrowkeys shortcuts should be used only when the higlighter or the toolbar are focused
Categories
(DevTools :: General, defect)
Tracking
(firefox11-, firefox12 fixed)
RESOLVED
FIXED
Firefox 12
People
(Reporter: paul, Assigned: paul)
References
Details
(Whiteboard: [qa+])
Attachments
(2 files, 2 obsolete files)
15.17 KB,
patch
|
Details | Diff | Splinter Review | |
14.99 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 3•13 years ago
|
||
Assignee | ||
Comment 4•13 years ago
|
||
We can't have the same event logic for the arrowkeys and the other keys. Because we don't want the arrow keys to be used when we are (focused) in the sidebar or in the HTML tree, because the keys mean something else there.
We can't move all the event in the same place because some keys are used everywhere (ESC for example).
So in this patch, I moved all the arrowkeys event logic in the breadcrumbs code because the browsing-logic should follow the current breadcrumbs layout (see bug 719834).
Only 3 elements of the UI should use the arrowkey events:
- Toolbar (not just the breadcrumbs)
- The highlighter veil
- The content window (because the highlighter veil can be key-event-unsensitive with pointer-events:none)
Assignee | ||
Comment 5•13 years ago
|
||
Well, no. I think I get that wrong.
Assignee | ||
Updated•13 years ago
|
Attachment #590309 -
Attachment is obsolete: true
Assignee | ||
Comment 6•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Attachment #590385 -
Flags: review?(rcampbell)
Comment 8•13 years ago
|
||
Comment on attachment 590385 [details] [diff] [review]
patch v3
+ /**
+ * Remove the event listeners for the arrowkeys.
+ */
+ cleanNavigationKeys:
I might change that name to "clearNavigationKeys" or even "remove".
Presumably the existing unittests work for this?
Attachment #590385 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 9•13 years ago
|
||
Assignee | ||
Updated•13 years ago
|
Whiteboard: [land-in-fx-team]
Assignee | ||
Updated•13 years ago
|
Attachment #590385 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → paul
Assignee | ||
Updated•13 years ago
|
tracking-firefox11:
--- → ?
Assignee | ||
Comment 10•13 years ago
|
||
Assignee | ||
Comment 11•13 years ago
|
||
status-firefox12:
--- → fixed
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 12•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 12
Comment 13•13 years ago
|
||
This does not appear to be critical enough to track, although you can make your case for uplifting to Beta 11 in a nomination.
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•