719933 - In the Inspector, the arrowkeys shortcuts should be used only when the higlighter or the toolbar are focused

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 3

[Paul Rouget [:paul]]

Attachment: patch v1

Comment 4

[Paul Rouget [:paul]]

We can't have the same event logic for the arrowkeys and the other keys. Because we don't want the arrow keys to be used when we are (focused) in the sidebar or in the HTML tree, because the keys mean something else there.

We can't move all the event in the same place because some keys are used everywhere (ESC for example).

So in this patch, I moved all the arrowkeys event logic in the breadcrumbs code because the browsing-logic should follow the current breadcrumbs layout (see bug 719834).

Only 3 elements of the UI should use the arrowkey events:
- Toolbar (not just the breadcrumbs)
- The highlighter veil
- The content window (because the highlighter veil can be key-event-unsensitive with pointer-events:none)

Comment 5

[Paul Rouget [:paul]]

Well, no. I think I get that wrong.

Comment 6

[Paul Rouget [:paul]]

Attachment: patch v3

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 590385 [details] [diff] [review]
patch v3

+  /**
+   * Remove the event listeners for the arrowkeys.
+   */
+   cleanNavigationKeys:

I might change that name to "clearNavigationKeys" or even "remove".

Presumably the existing unittests work for this?

Comment 9

[Paul Rouget [:paul]]

Attachment: patch v3.1

Comment 10

[Paul Rouget [:paul]]

Attachment: patch 3.1 - rebased

Comment 11

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/01a1a9d50106

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/01a1a9d50106

Comment 13

[Alex Keybl [:akeybl]]

This does not appear to be critical enough to track, although you can make your case for uplifting to Beta 11 in a nomination.