Bug 719986 (blacklist-xrender)

Blacklist XRender on machines where it's not useful

NEW
Unassigned

Status

()

Core
Graphics
6 years ago
6 years ago

People

(Reporter: jrmuizel, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
There are lots of places where XRender is worse than software. We should use software in those cases.
If we have a choice, we should probably never use XRender, if only because it's at least blocking us from upgrading the NVIDIA driver on linux slaves (bug 684165) which is a blocker for enabling GL layers acceleration. Also, if we could not use X pixmaps at all that would allow us to avoid bad interaction with GL which is likely a blocker for GL layers too (see blockers of bug 594876).

I hope that Skia would give us that, but if you know a quick way to do that with Cairo, by all means do it.
(Reporter)

Comment 2

6 years ago
(In reply to Benoit Jacob [:bjacob] from comment #1)
> If we have a choice, we should probably never use XRender, if only because
> it's at least blocking us from upgrading the NVIDIA driver on linux slaves
> (bug 684165) which is a blocker for enabling GL layers acceleration. Also,
> if we could not use X pixmaps at all that would allow us to avoid bad
> interaction with GL which is likely a blocker for GL layers too (see
> blockers of bug 594876).
> 
> I hope that Skia would give us that, but if you know a quick way to do that
> with Cairo, by all means do it.

Yes. We can just use cairo image surfaces. There are no problems that Skia solves here beyond some extra performance in some situations.
The problem that skia solves is that there are people working on the patch in bug 702158.

If it's easy to switch cairo to the image backend, please do it.
(Reporter)

Updated

6 years ago
Blocks: 403268
(Reporter)

Updated

6 years ago
Blocks: 383292
(Reporter)

Updated

6 years ago
Alias: blacklist-xrender
(Reporter)

Updated

6 years ago
Blocks: 404557
No longer blocks: 403268
Blacklisting XRender where there are serious problems makes sense, and perhaps even on platforms where XRender uses software it may be a win.

(In reply to Benoit Jacob [:bjacob] from comment #3)
> If it's easy to switch cairo to the image backend, please do it.

It's easy to switch, but hard to make it fast.

Any advantages of switching off XRender have to be weighed against the disadvantages of turning off 2D acceleration and having to read back GTK2 themes from VRAM.

http://www.hackermusings.com/2012/05/firefoxs-graphics-performance-on-x11/
You need to log in before you can comment on or make changes to this bug.