The default bug view has changed. See this FAQ.

Move Tab:Foo listeners and associated tab logic into Tabs

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P4
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Follow-up to cleanup from bug 719494. This will help clean up GeckoApp.
(Assignee)

Comment 1

5 years ago
Created attachment 590875 [details] [diff] [review]
patch

This doesn't necessarily help with the performance problems we've been seeing, but it makes it easier to follow the tab logic, and it's nice to move some things out of GeckoApp.
Attachment #590875 - Flags: review?(mbrubeck)
Attachment #590875 - Flags: review?(mbrubeck) → review+
Priority: -- → P4
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a9e2a1b1767
https://hg.mozilla.org/mozilla-central/rev/3a9e2a1b1767
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
(Assignee)

Comment 4

5 years ago
Comment on attachment 590875 [details] [diff] [review]
patch

[Approval Request Comment]
Code clean-up. We'll probably write patches on top of this, so it would be good to be in Aurora to prevent conflicts. Landed on m-c this morning, so it will be in Nightly tomorrow.
Attachment #590875 - Flags: approval-mozilla-aurora?

Comment 5

5 years ago
Comment on attachment 590875 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #590875 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/409847603071
status-firefox11: --- → fixed
status-firefox12: --- → fixed

Updated

5 years ago
Keywords: fennecnative-betablocker
Is this one really a beta blocker? It's a P4 code refactor.
sorry, I thought I removed it. was going through tab perf bugs to make sure we test them.
Keywords: fennecnative-betablocker
You need to log in before you can comment on or make changes to this bug.