Closed Bug 720048 Opened 13 years ago Closed 13 years ago

Move Tab:Foo listeners and associated tab logic into Tabs

Categories

(Firefox for Android Graveyard :: General, defect, P4)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect

Tracking

(firefox11 fixed, firefox12 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- fixed
firefox12 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

Details

Attachments

(1 file)

patch
9.50 KB, patch
mbrubeck
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Follow-up to cleanup from bug 719494. This will help clean up GeckoApp.
Attached patch patch — — Splinter Review 
This doesn't necessarily help with the performance problems we've been seeing, but it makes it easier to follow the tab logic, and it's nice to move some things out of GeckoApp.
Attachment #590875 - Flags: review?(mbrubeck)
Attachment #590875 - Flags: review?(mbrubeck) → review+
Priority: -- → P4
https://hg.mozilla.org/mozilla-central/rev/3a9e2a1b1767
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 590875 [details] [diff] [review]
patch

[Approval Request Comment]
Code clean-up. We'll probably write patches on top of this, so it would be good to be in Aurora to prevent conflicts. Landed on m-c this morning, so it will be in Nightly tomorrow.
Attachment #590875 - Flags: approval-mozilla-aurora?
Comment on attachment 590875 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #590875 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Is this one really a beta blocker? It's a P4 code refactor.
sorry, I thought I removed it. was going through tab perf bugs to make sure we test them.
Keywords: fennecnative-betablocker
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: