re-merge StackSpace.h with Stack.h, extract gc/Root.h

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 590418 [details] [diff] [review]
re-merge and extract gc/Root.h

For lame INSTALLED_HEADER reasons (which were graciously fixed by Ms2ger in bug 677079), StackSpace was split off from Stack.h.  This patch puts them back together.  In the meantime, a cyclic dependency emerged (jscntxt -> Stack -> jsfun -> jsscript -> jsscope -> jscntxt (to get js::Root)).  The fix, which seems good even by itself, is to hoist js::Root and kin (and the nice comment) into gc/Root.h (analogous to gc/Barrier.h).
Attachment #590418 - Flags: review?(bhackett1024)
Attachment #590418 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 1

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1023b9920a8d
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/1023b9920a8d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.