Last Comment Bug 720067 - re-merge StackSpace.h with Stack.h, extract gc/Root.h
: re-merge StackSpace.h with Stack.h, extract gc/Root.h
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
-- normal (vote)
: mozilla12
Assigned To: Luke Wagner [:luke]
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-01-20 19:50 PST by Luke Wagner [:luke]
Modified: 2012-01-24 04:49 PST (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

re-merge and extract gc/Root.h (53.26 KB, patch)
2012-01-20 19:50 PST, Luke Wagner [:luke]
bhackett1024: review+
Details | Diff | Splinter Review

Description User image Luke Wagner [:luke] 2012-01-20 19:50:52 PST
Created attachment 590418 [details] [diff] [review]
re-merge and extract gc/Root.h

For lame INSTALLED_HEADER reasons (which were graciously fixed by Ms2ger in bug 677079), StackSpace was split off from Stack.h.  This patch puts them back together.  In the meantime, a cyclic dependency emerged (jscntxt -> Stack -> jsfun -> jsscript -> jsscope -> jscntxt (to get js::Root)).  The fix, which seems good even by itself, is to hoist js::Root and kin (and the nice comment) into gc/Root.h (analogous to gc/Barrier.h).
Comment 2 User image Marco Bonardo [::mak] 2012-01-24 04:49:05 PST

Note You need to log in before you can comment on or make changes to this bug.