720095 - SimpleTest/EventUtils.js: fix some strict warnings and nits

Status: RESOLVED FIXED

(Testing :: Mochitest, defect, P3)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1-mochitest) Fix some strict warnings and nits [Checked in: See comment 4]

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 590444 [details] [diff] [review]
(Av1-mochitest) Fix some strict warnings and nits
[Checked in: See comment 4]

Succeeded as
https://tbpl.mozilla.org/?tree=Try&rev=8c2542206d3b
https://tbpl.mozilla.org/?tree=Try&rev=bbcd1bc991f9

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 590444 [details] [diff] [review]
(Av1-mochitest) Fix some strict warnings and nits
[Checked in: See comment 4]

Review of attachment 590444 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with one change.

::: testing/mochitest/tests/SimpleTest/EventUtils.js
@@ -508,5 @@
>    // we need parent.SpecialPowers for:
>    //  layout/base/tests/test_reftests_with_caret.html
>    //  chrome: toolkit/content/tests/chrome/test_findbar.xul
>    //  chrome: toolkit/content/tests/chrome/test_popup_anchor.xul
> -  if ("SpecialPowers" in window && window.SpecialPowers != undefined) {

Please don't remove curly braces from single-line if blocks.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 590444 [details] [diff] [review]
(Av1-mochitest) Fix some strict warnings and nits
[Checked in: See comment 4]

https://hg.mozilla.org/mozilla-central/rev/ed9d9eb609ba
Av1-mochitest, with comment 3 suggestion(s),
and unbitrotted.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-peptest-sync) EventUtils.js: Fix some strict warnings and nits

Sync'ed with patch Av1-mochitest.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1-mail) EventUtils.js: Fix some strict warnings and nits [Moved to bug 720744]

3rd time the "stdlib" file.

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 591139 [details] [diff] [review]
(Cv1-mail) EventUtils.js: Fix some strict warnings and nits
[Moved to bug 720744]

This needs to be fixed in the mozmill repository first. iirc the correct component is Testing:Mozmill. Once it has been fixed there we'll upgrade the version of MozMill that Thunderbird uses at some stage.

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 591139 [details] [diff] [review]
(Cv1-mail) EventUtils.js: Fix some strict warnings and nits
[Moved to bug 720744]

(In reply to Mark Banner (:standard8) from comment #7)
> This needs to be fixed in the mozmill repository first. iirc the correct
> component is Testing:Mozmill.

I did not know. I filed bug 720744.

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Bv2-mochitest) EventUtils.js: Fix 2 more nits

SimpleTest part of patch Bv1-peptest-sync only.

Comment 10

[(not currently active) Ted Mielczarek]

Comment on attachment 591157 [details] [diff] [review]
(Bv2-mochitest) EventUtils.js: Fix 2 more nits

Review of attachment 591157 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think it's worth a separate patch to fix nits of this small magnitude. If you're fixing something else, just roll it in there.