Last Comment Bug 720124 - Remove dead code from HTMLContentSink
: Remove dead code from HTMLContentSink
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-21 06:39 PST by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-01-25 07:33 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Part a: frameset - link - style - doctype (21.97 KB, patch)
2012-01-21 06:39 PST, :Ms2ger (⌚ UTC+1/+2)
hsivonen: review+
Details | Diff | Splinter Review
Part b: AddDocTypeDecl (9.82 KB, patch)
2012-01-21 06:40 PST, :Ms2ger (⌚ UTC+1/+2)
hsivonen: review+
Details | Diff | Splinter Review
Part c: mNumOpenIFRAMES (1.78 KB, patch)
2012-01-21 06:45 PST, :Ms2ger (⌚ UTC+1/+2)
hsivonen: review+
Details | Diff | Splinter Review
Part d: mInsideNoXXXTag (3.37 KB, patch)
2012-01-21 09:38 PST, :Ms2ger (⌚ UTC+1/+2)
hsivonen: review+
Details | Diff | Splinter Review
Part e: meta (1001 bytes, patch)
2012-01-21 09:39 PST, :Ms2ger (⌚ UTC+1/+2)
hsivonen: review+
Details | Diff | Splinter Review
Part f: form (13.14 KB, patch)
2012-01-21 09:40 PST, :Ms2ger (⌚ UTC+1/+2)
hsivonen: review+
Details | Diff | Splinter Review
Part g: IsFormOnStack (7.80 KB, patch)
2012-01-21 09:41 PST, :Ms2ger (⌚ UTC+1/+2)
hsivonen: review+
Details | Diff | Splinter Review
Part h: AddProcessingInstruction (8.90 KB, patch)
2012-01-21 09:41 PST, :Ms2ger (⌚ UTC+1/+2)
hsivonen: review+
Details | Diff | Splinter Review
Part i: AddComment (10.69 KB, patch)
2012-01-21 09:42 PST, :Ms2ger (⌚ UTC+1/+2)
hsivonen: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-01-21 06:39:04 PST
Created attachment 590467 [details] [diff] [review]
Part a: frameset - link - style - doctype
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2012-01-21 06:40:09 PST
Created attachment 590470 [details] [diff] [review]
Part b: AddDocTypeDecl
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-01-21 06:45:33 PST
Created attachment 590472 [details] [diff] [review]
Part c: mNumOpenIFRAMES

I can't even find a tree on MXR where this was used for anything
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2012-01-21 09:38:59 PST
Created attachment 590481 [details] [diff] [review]
Part d: mInsideNoXXXTag
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2012-01-21 09:39:57 PST
Created attachment 590482 [details] [diff] [review]
Part e: meta
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2012-01-21 09:40:41 PST
Created attachment 590483 [details] [diff] [review]
Part f: form
Comment 6 :Ms2ger (⌚ UTC+1/+2) 2012-01-21 09:41:22 PST
Created attachment 590484 [details] [diff] [review]
Part g: IsFormOnStack
Comment 7 :Ms2ger (⌚ UTC+1/+2) 2012-01-21 09:41:46 PST
Created attachment 590485 [details] [diff] [review]
Part h: AddProcessingInstruction
Comment 8 :Ms2ger (⌚ UTC+1/+2) 2012-01-21 09:42:16 PST
Created attachment 590486 [details] [diff] [review]
Part i: AddComment
Comment 9 Henri Sivonen (:hsivonen) 2012-01-22 00:19:53 PST
Comment on attachment 590470 [details] [diff] [review]
Part b: AddDocTypeDecl

In theory, you should revise the IID of nsIHTMLContentSink.
Comment 10 Henri Sivonen (:hsivonen) 2012-01-22 00:24:26 PST
Comment on attachment 590484 [details] [diff] [review]
Part g: IsFormOnStack

Theoretical IID bump.
Comment 11 Henri Sivonen (:hsivonen) 2012-01-22 00:28:19 PST
Comment on attachment 590486 [details] [diff] [review]
Part i: AddComment

Thanks for removing this cruft!

BTW, nsLoggingSink is only useful for diagnostics while fixing this bug. If you feel you don't need nsLoggingSink diagnostics for fixing this bug, feel free to delete nsLoggingSink altogether.

Note You need to log in before you can comment on or make changes to this bug.