Closed
Bug 720124
Opened 12 years ago
Closed 12 years ago
Remove dead code from HTMLContentSink
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(9 files)
|
21.97 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
9.82 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
1.78 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
3.37 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
1001 bytes,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
13.14 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
7.80 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
8.90 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
10.69 KB,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #590467 -
Flags: review?(hsivonen)
|
Assignee | |
Updated•12 years ago
|
Attachment #590467 -
Attachment description: Part a: fameset - link - style - doctype → Part a: frameset - link - style - doctype
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #590470 -
Flags: review?(hsivonen)
|
|
Assignee | |
Comment 2•12 years ago
|
||
I can't even find a tree on MXR where this was used for anything
Attachment #590472 -
Flags: review?(hsivonen)
|
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #590481 -
Flags: review?(hsivonen)
|
|
Assignee | |
Comment 4•12 years ago
|
||
Attachment #590482 -
Flags: review?(hsivonen)
|
|
Assignee | |
Comment 5•12 years ago
|
||
Attachment #590483 -
Flags: review?(hsivonen)
|
|
Assignee | |
Comment 6•12 years ago
|
||
Attachment #590484 -
Flags: review?(hsivonen)
|
|
Assignee | |
Comment 7•12 years ago
|
||
Attachment #590485 -
Flags: review?(hsivonen)
|
|
Assignee | |
Comment 8•12 years ago
|
||
Attachment #590486 -
Flags: review?(hsivonen)
|
||
Updated•12 years ago
|
Attachment #590467 -
Flags: review?(hsivonen) → review+
|
|
||
Comment 9•12 years ago
|
||
Comment on attachment 590470 [details] [diff] [review] Part b: AddDocTypeDecl In theory, you should revise the IID of nsIHTMLContentSink.
Attachment #590470 -
Flags: review?(hsivonen) → review+
|
|
||
Updated•12 years ago
|
Attachment #590472 -
Flags: review?(hsivonen) → review+
|
|
||
Updated•12 years ago
|
Attachment #590481 -
Flags: review?(hsivonen) → review+
|
|
||
Updated•12 years ago
|
Attachment #590482 -
Flags: review?(hsivonen) → review+
|
|
||
Updated•12 years ago
|
Attachment #590483 -
Flags: review?(hsivonen) → review+
|
|
||
Comment 10•12 years ago
|
||
Comment on attachment 590484 [details] [diff] [review] Part g: IsFormOnStack Theoretical IID bump.
Attachment #590484 -
Flags: review?(hsivonen) → review+
|
|
||
Updated•12 years ago
|
Attachment #590485 -
Flags: review?(hsivonen) → review+
|
|
||
Comment 11•12 years ago
|
||
Comment on attachment 590486 [details] [diff] [review] Part i: AddComment Thanks for removing this cruft! BTW, nsLoggingSink is only useful for diagnostics while fixing this bug. If you feel you don't need nsLoggingSink diagnostics for fixing this bug, feel free to delete nsLoggingSink altogether.
Attachment #590486 -
Flags: review?(hsivonen) → review+
|
|
Assignee | |
Comment 12•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/086f5438276f https://hg.mozilla.org/mozilla-central/rev/90ce75a0083f https://hg.mozilla.org/mozilla-central/rev/2bb09ec057e6 https://hg.mozilla.org/mozilla-central/rev/8232ce31f221 https://hg.mozilla.org/mozilla-central/rev/5c0b40af4d51 https://hg.mozilla.org/mozilla-central/rev/92474bceca8a https://hg.mozilla.org/mozilla-central/rev/ffa1adda4c4f https://hg.mozilla.org/mozilla-central/rev/86377c75fbca https://hg.mozilla.org/mozilla-central/rev/048568c7684f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•