Closed Bug 720124 Opened 9 years ago Closed 9 years ago

Remove dead code from HTMLContentSink

Categories

(Core :: DOM: HTML Parser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(9 files)

No description provided.
Attachment #590467 - Flags: review?(hsivonen)
Attachment #590467 - Attachment description: Part a: fameset - link - style - doctype → Part a: frameset - link - style - doctype
Attachment #590470 - Flags: review?(hsivonen)
I can't even find a tree on MXR where this was used for anything
Attachment #590472 - Flags: review?(hsivonen)
Attachment #590481 - Flags: review?(hsivonen)
Attached patch Part e: metaSplinter Review
Attachment #590482 - Flags: review?(hsivonen)
Attached patch Part f: formSplinter Review
Attachment #590483 - Flags: review?(hsivonen)
Attachment #590484 - Flags: review?(hsivonen)
Attachment #590485 - Flags: review?(hsivonen)
Attachment #590486 - Flags: review?(hsivonen)
Attachment #590467 - Flags: review?(hsivonen) → review+
Comment on attachment 590470 [details] [diff] [review]
Part b: AddDocTypeDecl

In theory, you should revise the IID of nsIHTMLContentSink.
Attachment #590470 - Flags: review?(hsivonen) → review+
Attachment #590472 - Flags: review?(hsivonen) → review+
Attachment #590481 - Flags: review?(hsivonen) → review+
Attachment #590482 - Flags: review?(hsivonen) → review+
Attachment #590483 - Flags: review?(hsivonen) → review+
Comment on attachment 590484 [details] [diff] [review]
Part g: IsFormOnStack

Theoretical IID bump.
Attachment #590484 - Flags: review?(hsivonen) → review+
Attachment #590485 - Flags: review?(hsivonen) → review+
Comment on attachment 590486 [details] [diff] [review]
Part i: AddComment

Thanks for removing this cruft!

BTW, nsLoggingSink is only useful for diagnostics while fixing this bug. If you feel you don't need nsLoggingSink diagnostics for fixing this bug, feel free to delete nsLoggingSink altogether.
Attachment #590486 - Flags: review?(hsivonen) → review+
You need to log in before you can comment on or make changes to this bug.