Remove dead code from HTMLContentSink

RESOLVED FIXED in mozilla12

Status

()

Core
HTML: Parser
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(9 attachments)

(Assignee)

Description

5 years ago
Created attachment 590467 [details] [diff] [review]
Part a: frameset - link - style - doctype
Attachment #590467 - Flags: review?(hsivonen)
(Assignee)

Updated

5 years ago
Attachment #590467 - Attachment description: Part a: fameset - link - style - doctype → Part a: frameset - link - style - doctype
(Assignee)

Comment 1

5 years ago
Created attachment 590470 [details] [diff] [review]
Part b: AddDocTypeDecl
Attachment #590470 - Flags: review?(hsivonen)
(Assignee)

Comment 2

5 years ago
Created attachment 590472 [details] [diff] [review]
Part c: mNumOpenIFRAMES

I can't even find a tree on MXR where this was used for anything
Attachment #590472 - Flags: review?(hsivonen)
(Assignee)

Comment 3

5 years ago
Created attachment 590481 [details] [diff] [review]
Part d: mInsideNoXXXTag
Attachment #590481 - Flags: review?(hsivonen)
(Assignee)

Comment 4

5 years ago
Created attachment 590482 [details] [diff] [review]
Part e: meta
Attachment #590482 - Flags: review?(hsivonen)
(Assignee)

Comment 5

5 years ago
Created attachment 590483 [details] [diff] [review]
Part f: form
Attachment #590483 - Flags: review?(hsivonen)
(Assignee)

Comment 6

5 years ago
Created attachment 590484 [details] [diff] [review]
Part g: IsFormOnStack
Attachment #590484 - Flags: review?(hsivonen)
(Assignee)

Comment 7

5 years ago
Created attachment 590485 [details] [diff] [review]
Part h: AddProcessingInstruction
Attachment #590485 - Flags: review?(hsivonen)
(Assignee)

Comment 8

5 years ago
Created attachment 590486 [details] [diff] [review]
Part i: AddComment
Attachment #590486 - Flags: review?(hsivonen)
Attachment #590467 - Flags: review?(hsivonen) → review+
Comment on attachment 590470 [details] [diff] [review]
Part b: AddDocTypeDecl

In theory, you should revise the IID of nsIHTMLContentSink.
Attachment #590470 - Flags: review?(hsivonen) → review+
Attachment #590472 - Flags: review?(hsivonen) → review+
Attachment #590481 - Flags: review?(hsivonen) → review+
Attachment #590482 - Flags: review?(hsivonen) → review+
Attachment #590483 - Flags: review?(hsivonen) → review+
Comment on attachment 590484 [details] [diff] [review]
Part g: IsFormOnStack

Theoretical IID bump.
Attachment #590484 - Flags: review?(hsivonen) → review+
Attachment #590485 - Flags: review?(hsivonen) → review+
Comment on attachment 590486 [details] [diff] [review]
Part i: AddComment

Thanks for removing this cruft!

BTW, nsLoggingSink is only useful for diagnostics while fixing this bug. If you feel you don't need nsLoggingSink diagnostics for fixing this bug, feel free to delete nsLoggingSink altogether.
Attachment #590486 - Flags: review?(hsivonen) → review+
(Assignee)

Comment 12

5 years ago
https://hg.mozilla.org/mozilla-central/rev/086f5438276f
https://hg.mozilla.org/mozilla-central/rev/90ce75a0083f
https://hg.mozilla.org/mozilla-central/rev/2bb09ec057e6
https://hg.mozilla.org/mozilla-central/rev/8232ce31f221
https://hg.mozilla.org/mozilla-central/rev/5c0b40af4d51
https://hg.mozilla.org/mozilla-central/rev/92474bceca8a
https://hg.mozilla.org/mozilla-central/rev/ffa1adda4c4f
https://hg.mozilla.org/mozilla-central/rev/86377c75fbca
https://hg.mozilla.org/mozilla-central/rev/048568c7684f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.