ARIA button should expose press action

RESOLVED FIXED in mozilla13

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: surkov, Assigned: Murali)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla13
access
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
ARIA button exposes click action while it should expose 'press' action what makes compatible with native button widgets.
(Reporter)

Comment 1

6 years ago
1) Introduce ePressAction in EActionRule
2) Change eClickAction to ePressAction in nsARAIMap.cpp for "button" role (http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsARIAMap.cpp#108)
3) Fix nsAccessible::GetActionName
4) add tests at actions/test_aria.html (http://mxr.mozilla.org/mozilla-central/source/accessible/tests/mochitest/actions/test_aria.html?force=1)
Whiteboard: [good first bug][mentor=surkov.alexander@gmail.com][lang=c++]
(Assignee)

Comment 2

6 years ago
Hi, I'm new here. I am interested in fixing this bug. Can you please guide me? Thanks!
(Reporter)

Comment 3

6 years ago
(In reply to Murali from comment #2)
> Hi, I'm new here. I am interested in fixing this bug. Can you please guide
> me? Thanks!

You need to set up your build environment and etc (follow https://developer.mozilla.org/en/Introduction). When you're ready to work on patch then follow instructions given in comment #1. You can use http://mxr.mozilla.org/mozilla-central tool to locate methods, class names etc. If you have question then don't hesitate to ask.
(Assignee)

Comment 4

6 years ago
I have made it to step 2 successfully.

Can you please tell me whether my understanding of step 3 is correct?

Change the following in nsAccessible.cpp
1843    case eClickAction:
1844      aName.AssignLiteral("click");
1845      return NS_OK;

to

1843    case ePressAction:
1844      aName.AssignLiteral("press");
1845      return NS_OK;

Also, I'm not quite sure what to do in step 4. Could you please guide me? Thanks! :)
(Reporter)

Comment 5

6 years ago
(In reply to Murali from comment #4)
> I have made it to step 2 successfully.
> 
> Can you please tell me whether my understanding of step 3 is correct?
> 
> Change the following in nsAccessible.cpp
> 1843    case eClickAction:
> 1844      aName.AssignLiteral("click");
> 1845      return NS_OK;
> 
> to
> 
> 1843    case ePressAction:
> 1844      aName.AssignLiteral("press");
> 1845      return NS_OK;

add (not replace)

> Also, I'm not quite sure what to do in step 4. Could you please guide me?
> Thanks! :)

you need to find role="button" elements and make sure they expose "press" action (not "click" action). All actions are described by actionsArray variable. To get an idea how these things work exactly you need to look at ../actions.js file.
(Assignee)

Comment 6

6 years ago
Created attachment 593048 [details] [diff] [review]
Buttons made to expose Press Action

Could you kindly let me know of the changes I might have to do to this patch? Thank you so much for the help!
Attachment #593048 - Flags: review?(surkov.alexander)
(Reporter)

Comment 7

6 years ago
Comment on attachment 593048 [details] [diff] [review]
Buttons made to expose Press Action

r=me, thanks

do you want me to land the patch?
Attachment #593048 - Flags: review?(surkov.alexander) → review+
(Reporter)

Updated

6 years ago
Assignee: nobody → murali.sr92
Status: NEW → ASSIGNED
(Assignee)

Comment 8

6 years ago
Sure, thanks a lot for all the guidance! I am really looking forward to work on more challenging bugs soon! :)
(Reporter)

Comment 9

6 years ago
(In reply to Murali from comment #8)
> Sure, thanks a lot for all the guidance! I am really looking forward to work
> on more challenging bugs soon! :)

since you know our tests structure then you might want to look at bug 702560
(Reporter)

Comment 10

6 years ago
try server build http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/surkov.alexander@gmail.com-31c80460f127
(Reporter)

Comment 11

6 years ago
inbound land https://hg.mozilla.org/integration/mozilla-inbound/rev/42705e4d1175
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/42705e4d1175
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.