Crash [@ nsGenericHTMLFrameElement::OnLocationChange]

VERIFIED FIXED in Firefox 12

Status

()

Core
Document Navigation
--
critical
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: Justin Lebar (not reading bugmail))

Tracking

(Blocks: 1 bug, {crash, testcase})

Trunk
mozilla12
x86_64
Mac OS X
crash, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox12 verified)

Details

(Whiteboard: [qa!])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 590505 [details]
testcase (must be local) (crashes Firefox when loaded)
(Reporter)

Comment 1

6 years ago
Created attachment 590506 [details]
stack trace
(Assignee)

Comment 2

6 years ago
This is likely my bug.
Blocks: 710231
(Assignee)

Comment 3

6 years ago
What the heck does a null URI in nsIWebProgressObserver::OnLocationChange mean?
(Assignee)

Updated

6 years ago
Assignee: nobody → justin.lebar+bug
(Assignee)

Comment 4

6 years ago
Apparently a null URI means "data: URI".  Lame!
(Assignee)

Comment 5

6 years ago
Actually, it seems to mean "error page," which is a bit more reasonable.
(Assignee)

Comment 6

6 years ago
Created attachment 590580 [details] [diff] [review]
Patch v1

I tried to add a test for this crash, but I couldn't get it to work, presumably because the testcase must be local.
Attachment #590580 - Flags: review?(bugs)

Comment 7

6 years ago
Comment on attachment 590580 [details] [diff] [review]
Patch v1

I'd prefer 
if (!aURI) {
  return NS_OK;
}
Attachment #590580 - Flags: review?(bugs) → review+
(Assignee)

Comment 8

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/10c3bb782aff
status-firefox12: --- → fixed
https://hg.mozilla.org/mozilla-central/rev/10c3bb782aff
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Whiteboard: [qa+]
Blocks: 740836

Comment 10

5 years ago
I 've loaded the testcase from the attachement and I get a square with "1" number inside it and after ~2 seconds I get an 404 Error - invalid bug ID/
If I hit back, the square is displayed.

Firefox didn't crash.
Can I change the resolution to Verified Fixed?
Thanks
(Reporter)

Comment 11

5 years ago
Vlad, please test with the testcase local rather than loading it from Bugzilla. (Right-click the testcase link and save it to your desktop, then open it from your desktop.)

Comment 12

5 years ago
I've opened the testcase from the desktop and the behavior is the same as per comment10. I'm getting the same 404 error but this time locally. 

No crash though on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0 beta 3
(Reporter)

Comment 13

5 years ago
Vlad, sounds good :)

Comment 14

5 years ago
Considering comment12 and comment13, setting resolution to Verified Fixed on Firefox 12.
Status: RESOLVED → VERIFIED
status-firefox12: fixed → verified
Whiteboard: [qa+] → [qa!]
(Assignee)

Updated

5 years ago
No longer blocks: 740836
Blocks: 740836
You need to log in before you can comment on or make changes to this bug.