Closed Bug 720157 Opened 8 years ago Closed 8 years ago

Crash [@ nsGenericHTMLFrameElement::OnLocationChange]

Categories

(Core :: DOM: Navigation, defect, critical)

x86_64
macOS
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla12
Tracking Status
firefox12 --- verified

People

(Reporter: jruderman, Assigned: justin.lebar+bug)

References

(Blocks 1 open bug)

Details

(Keywords: crash, testcase, Whiteboard: [qa!])

Attachments

(3 files)

No description provided.
Attached file stack trace
This is likely my bug.
Blocks: 710231
What the heck does a null URI in nsIWebProgressObserver::OnLocationChange mean?
Assignee: nobody → justin.lebar+bug
Apparently a null URI means "data: URI".  Lame!
Actually, it seems to mean "error page," which is a bit more reasonable.
Attached patch Patch v1Splinter Review
I tried to add a test for this crash, but I couldn't get it to work, presumably because the testcase must be local.
Attachment #590580 - Flags: review?(bugs)
Comment on attachment 590580 [details] [diff] [review]
Patch v1

I'd prefer 
if (!aURI) {
  return NS_OK;
}
Attachment #590580 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/10c3bb782aff
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Whiteboard: [qa+]
I 've loaded the testcase from the attachement and I get a square with "1" number inside it and after ~2 seconds I get an 404 Error - invalid bug ID/
If I hit back, the square is displayed.

Firefox didn't crash.
Can I change the resolution to Verified Fixed?
Thanks
Vlad, please test with the testcase local rather than loading it from Bugzilla. (Right-click the testcase link and save it to your desktop, then open it from your desktop.)
I've opened the testcase from the desktop and the behavior is the same as per comment10. I'm getting the same 404 error but this time locally. 

No crash though on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0 beta 3
Vlad, sounds good :)
Considering comment12 and comment13, setting resolution to Verified Fixed on Firefox 12.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
No longer blocks: 740836
You need to log in before you can comment on or make changes to this bug.