720157 - Crash [@ nsGenericHTMLFrameElement::OnLocationChange]

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect)

Description

[Jesse Ruderman]

Attachment: testcase (must be local) (crashes Firefox when loaded)

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Justin Lebar (not reading bugmail)]

This is likely my bug.

Comment 3

[Justin Lebar (not reading bugmail)]

What the heck does a null URI in nsIWebProgressObserver::OnLocationChange mean?

Comment 4

[Justin Lebar (not reading bugmail)]

Apparently a null URI means "data: URI".  Lame!

Comment 5

[Justin Lebar (not reading bugmail)]

Actually, it seems to mean "error page," which is a bit more reasonable.

Comment 6

[Justin Lebar (not reading bugmail)]

Attachment: Patch v1

I tried to add a test for this crash, but I couldn't get it to work, presumably because the testcase must be local.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 590580 [details] [diff] [review]
Patch v1

I'd prefer 
if (!aURI) {
  return NS_OK;
}

Comment 8

[Justin Lebar (not reading bugmail)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/10c3bb782aff

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/10c3bb782aff

Comment 10

[Vlad [QA]]

I 've loaded the testcase from the attachement and I get a square with "1" number inside it and after ~2 seconds I get an 404 Error - invalid bug ID/
If I hit back, the square is displayed.

Firefox didn't crash.
Can I change the resolution to Verified Fixed?
Thanks

Comment 11

[Jesse Ruderman]

Vlad, please test with the testcase local rather than loading it from Bugzilla. (Right-click the testcase link and save it to your desktop, then open it from your desktop.)

Comment 12

[Vlad [QA]]

I've opened the testcase from the desktop and the behavior is the same as per comment10. I'm getting the same 404 error but this time locally. 

No crash though on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:12.0) Gecko/20100101 Firefox/12.0 beta 3

Comment 13

[Jesse Ruderman]

Vlad, sounds good :)

Comment 14

[Vlad [QA]]

Considering comment12 and comment13, setting resolution to Verified Fixed on Firefox 12.