The default bug view has changed. See this FAQ.

In pymake, the UnexportDirective class is missing a dump() method

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Michael Haggerty, Assigned: Michael Haggerty)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [pymake])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 590538 [details] [diff] [review]
Patch that adds UnexportDirective.dump()

If you run mkparse.py against a Makefile that contains an "unexport" statement, an exception is thrown:

Traceback (most recent call last):
  File "../pymake/mkparse.py", line 12, in <module>
    print stmts
  File "/home/mhagger/self/proj/pymake-hg/pymake/parserdata.py", line 510, in __str__
    self.dump(fd, '')
  File "/home/mhagger/self/proj/pymake-hg/pymake/parserdata.py", line 506, in dump
    s.dump(fd, indent)
AttributeError: 'UnexportDirective' object has no attribute 'dump'

The exception is caused by the fact that UnexportDirective does not implement the dump() method.

I will attach a patch that fixes the problem.
Assignee: nobody → mhagger
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
Whiteboard: [pymake]
Attachment #590538 - Flags: review?(benjamin)
Comment on attachment 590538 [details] [diff] [review]
Patch that adds UnexportDirective.dump()

Please push to the pymake repo and we'll get pick this up in m-c the next time we do an import (unless it's really important to you that we get it into the mozilla tree).
Attachment #590538 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
Whiteboard: [pymake] → [pymake] [checkin-needed to pymake repo]
(Assignee)

Comment 2

5 years ago
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #1)
> Please push to the pymake repo and we'll get pick this up in m-c the next
> time we do an import (unless it's really important to you that we get it
> into the mozilla tree).

There is no hurry on my account to get this in the mozilla tree; I have patched my copy locally and that is fine for now.

I am not a committer to pymake so I don't believe that I can push to the project.  (Therefore the bug should probably not remain assigned to me, but I don't know to whom I should assign it.)
That's ok, someone else can land it for you (I have marked the bug as checkin-needed, so will be picked up by myself/someone else soon). What first+last name do you wish to have on the commit?
(And thank you very much for the patch!)
(Assignee)

Comment 5

5 years ago
(In reply to Ed Morley [:edmorley] from comment #3)
> [...] What first+last name do you wish to have on the commit?

Michael Haggerty

(In reply to Ed Morley [:edmorley] from comment #4)
> (And thank you very much for the patch!)

My pleasure.  pymake is quite cool and I expect it to save me a lot of work on a project that I am working on.
http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/87d436cd8974

Thanks for the patch!
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Whiteboard: [pymake] [checkin-needed to pymake repo] → [pymake]
You need to log in before you can comment on or make changes to this bug.