720215 - Warning dialog when quitting Firefox in private browsing while downloading doesn't actually work

Status: RESOLVED DUPLICATE of bug 679957

(Firefox :: Private Browsing, defect)

Description

[nobody10331033]

Attachment: 2012-01-22-195649_1024x600_scrot.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

In private browsing, start some downloads, then quit Firefox. A dialog, entitled "Cancel All Downloads?" appears, giving me the option of stopping the quitting process, or continuing the quitting process, cancelling one or more downloads in the process. However, the "Stay in Private Browsing Mode" button doesn't actually work.


Actual results:

Pressing "Stay in Private Browsing Mode" does the same thing as pressing "Cancel n Downloads" as well as pressing the escape key: Firefox always quits, cancelling downloads.


Expected results:

Pressing "Stay in Private Browsing Mode" should cancel the quitting, keeping Firefox open, in private browsing mode, and keep the downloads running as if the user never tried to quit in the first place.

Comment 1

[Josh Matthews [:jdm]]

This is a bit of a doozy. The dialog is actually being shown after the point at which it can make a difference, because the download manager doesn't notice that we're in private browsing mode when deciding whether there are non-resumable downloads in progress.

Comment 2

[Josh Matthews [:jdm]]

There's an important fix needed here to make nsDownloadManager::GetQuitBehaviour consider the value of mInPrivateBrowsing. However, just that change will make us show the same dialog box twice when attempting to quit from PB mode with >0 downloads in progress. The first dialog will allow the user to remain in PB mode and not exit, while the second will have no effect either way. I don't see any good way to prevent the second dialog without relying on the order of quit-application-granted observers :/

Comment 3

[Mardeg]

This looks like a dupe of bug 679957 which is assigned with a patch.

Comment 4

[(no longer active)]

This is indeed a dupe...