Don't do a default browser check in debug builds

RESOLVED FIXED in Firefox 12

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Dolske, Assigned: Dolske)

Tracking

unspecified
Firefox 12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 590618 [details] [diff] [review]
Patch v.1

Everyone, always, repeatedly:

  1) Build debug Firefox
  2) start with new profile to test something
  3) "Nightly is not currently set as your default browser.
      Would you like to make it your default browser?"
  4) FUUUUUUUUU no!

No one, ever:

  ...
  4) Why, yes, I want to make my debug build my default browser and appreciate
     it asking each time I create a new profile! In fact I wish it would prompt
     me over and over!
Attachment #590618 - Flags: review?
Comment on attachment 590618 [details] [diff] [review]
Patch v.1

This will cause the pref to be reset if you switch between DEBUG/non-DEBUG builds. Can you just disable the check in the code instead?
i.e. just make shouldCheckDefaultBrowser always false #ifdef DEBUG
(Assignee)

Comment 3

5 years ago
Created attachment 590625 [details] [diff] [review]
Patch v.2
Attachment #590618 - Attachment is obsolete: true
Attachment #590618 - Flags: review?
Attachment #590625 - Flags: review?(gavin.sharp)
Attachment #590625 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 4

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/75ddbfb943c7

Comment 5

5 years ago
\o/

https://hg.mozilla.org/mozilla-central/rev/75ddbfb943c7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
You need to log in before you can comment on or make changes to this bug.