Last Comment Bug 720288 - Don't do a default browser check in debug builds
: Don't do a default browser check in debug builds
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 12
Assigned To: Justin Dolske [:Dolske]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-22 19:03 PST by Justin Dolske [:Dolske]
Modified: 2012-01-23 11:51 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v.1 (1.22 KB, patch)
2012-01-22 19:03 PST, Justin Dolske [:Dolske]
no flags Details | Diff | Splinter Review
Patch v.2 (1.96 KB, patch)
2012-01-22 20:51 PST, Justin Dolske [:Dolske]
gavin.sharp: review+
Details | Diff | Splinter Review

Description Justin Dolske [:Dolske] 2012-01-22 19:03:29 PST
Created attachment 590618 [details] [diff] [review]
Patch v.1

Everyone, always, repeatedly:

  1) Build debug Firefox
  2) start with new profile to test something
  3) "Nightly is not currently set as your default browser.
      Would you like to make it your default browser?"
  4) FUUUUUUUUU no!

No one, ever:

  ...
  4) Why, yes, I want to make my debug build my default browser and appreciate
     it asking each time I create a new profile! In fact I wish it would prompt
     me over and over!
Comment 1 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-01-22 19:44:09 PST
Comment on attachment 590618 [details] [diff] [review]
Patch v.1

This will cause the pref to be reset if you switch between DEBUG/non-DEBUG builds. Can you just disable the check in the code instead?
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2012-01-22 20:06:32 PST
i.e. just make shouldCheckDefaultBrowser always false #ifdef DEBUG
Comment 3 Justin Dolske [:Dolske] 2012-01-22 20:51:21 PST
Created attachment 590625 [details] [diff] [review]
Patch v.2
Comment 5 Ed Morley [:emorley] 2012-01-23 11:51:26 PST
\o/

https://hg.mozilla.org/mozilla-central/rev/75ddbfb943c7

Note You need to log in before you can comment on or make changes to this bug.