Closed
Bug 720288
Opened 12 years ago
Closed 12 years ago
Don't do a default browser check in debug builds
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 12
People
(Reporter: Dolske, Assigned: Dolske)
Details
Attachments
(1 file, 1 obsolete file)
|
1.96 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
Everyone, always, repeatedly:
1) Build debug Firefox
2) start with new profile to test something
3) "Nightly is not currently set as your default browser.
Would you like to make it your default browser?"
4) FUUUUUUUUU no!
No one, ever:
...
4) Why, yes, I want to make my debug build my default browser and appreciate
it asking each time I create a new profile! In fact I wish it would prompt
me over and over!
Attachment #590618 -
Flags: review?
|
||
Comment 1•12 years ago
|
||
Comment on attachment 590618 [details] [diff] [review] Patch v.1 This will cause the pref to be reset if you switch between DEBUG/non-DEBUG builds. Can you just disable the check in the code instead?
|
|
||
Comment 2•12 years ago
|
||
i.e. just make shouldCheckDefaultBrowser always false #ifdef DEBUG
|
Assignee | |
Comment 3•12 years ago
|
||
Attachment #590618 -
Attachment is obsolete: true
Attachment #590618 -
Flags: review?
Attachment #590625 -
Flags: review?(gavin.sharp)
|
|
||
Updated•12 years ago
|
Attachment #590625 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/75ddbfb943c7
|
||
Comment 5•12 years ago
|
||
\o/ https://hg.mozilla.org/mozilla-central/rev/75ddbfb943c7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
You need to log in
before you can comment on or make changes to this bug.
Description
•