Last Comment Bug 720292 - add more cycle collector edge names
: add more cycle collector edge names
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla12
Assigned To: Andrew McCreight [:mccr8]
:
: Nathan Froyd [:froydnj]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-22 19:39 PST by Andrew McCreight [:mccr8]
Modified: 2012-01-24 04:59 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
add more edge names (10.76 KB, patch)
2012-01-22 19:41 PST, Andrew McCreight [:mccr8]
bugs: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2012-01-22 19:39:51 PST

    
Comment 1 Andrew McCreight [:mccr8] 2012-01-22 19:41:15 PST
Created attachment 590620 [details] [diff] [review]
add more edge names

Various classes that don't have edge names that have annoyed me in the past.
Comment 2 Andrew McCreight [:mccr8] 2012-01-22 19:59:26 PST
Comment on attachment 590620 [details] [diff] [review]
add more edge names

Let me know if you have any suggestions.  For instance, maybe "mPrototypeBinding->XBLDocumentInfo()" should just be "XBLDocumentInfo".  I can also attach some snippets from CC logs of what these objects look like with these changes if you like.
Comment 3 Olli Pettay [:smaug] 2012-01-23 05:32:15 PST
Comment on attachment 590620 [details] [diff] [review]
add more edge names


>         for (i = 0; i < elem->mNumAttributes; ++i) {
>             const nsAttrName& name = elem->mAttributes[i].mName;
>-            if (!name.IsAtom())
>+            if (!name.IsAtom()) {
>+                NS_CYCLE_COLLECTION_NOTE_EDGE_NAME(cb, "mAttributes[i]");
Could this be "mAttributes[i].mName.NodeInfo()"
Comment 4 Andrew McCreight [:mccr8] 2012-01-23 11:25:58 PST
(In reply to Olli Pettay [:smaug] from comment #3)
> Could this be "mAttributes[i].mName.NodeInfo()"
Sounds fine to me.

Putting it on try server in case of weirdness: https://tbpl.mozilla.org/?tree=Try&rev=a1e4ce92b747
Comment 5 Andrew McCreight [:mccr8] 2012-01-23 15:28:03 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/56ee4d79fd79
Comment 6 Marco Bonardo [::mak] 2012-01-24 04:59:45 PST
https://hg.mozilla.org/mozilla-central/rev/56ee4d79fd79

Note You need to log in before you can comment on or make changes to this bug.