720292 - add more cycle collector edge names

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: add more edge names

Various classes that don't have edge names that have annoyed me in the past.

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 590620 [details] [diff] [review]
add more edge names

Let me know if you have any suggestions.  For instance, maybe "mPrototypeBinding->XBLDocumentInfo()" should just be "XBLDocumentInfo".  I can also attach some snippets from CC logs of what these objects look like with these changes if you like.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 590620 [details] [diff] [review]
add more edge names


>         for (i = 0; i < elem->mNumAttributes; ++i) {
>             const nsAttrName& name = elem->mAttributes[i].mName;
>-            if (!name.IsAtom())
>+            if (!name.IsAtom()) {
>+                NS_CYCLE_COLLECTION_NOTE_EDGE_NAME(cb, "mAttributes[i]");
Could this be "mAttributes[i].mName.NodeInfo()"

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Olli Pettay [:smaug] from comment #3)
> Could this be "mAttributes[i].mName.NodeInfo()"
Sounds fine to me.

Putting it on try server in case of weirdness: https://tbpl.mozilla.org/?tree=Try&rev=a1e4ce92b747

Comment 5

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56ee4d79fd79

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/56ee4d79fd79