Closed Bug 720292 Opened 8 years ago Closed 8 years ago

add more cycle collector edge names

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

No description provided.
Various classes that don't have edge names that have annoyed me in the past.
Assignee: nobody → continuation
Comment on attachment 590620 [details] [diff] [review]
add more edge names

Let me know if you have any suggestions.  For instance, maybe "mPrototypeBinding->XBLDocumentInfo()" should just be "XBLDocumentInfo".  I can also attach some snippets from CC logs of what these objects look like with these changes if you like.
Attachment #590620 - Flags: review?(bugs)
Comment on attachment 590620 [details] [diff] [review]
add more edge names


>         for (i = 0; i < elem->mNumAttributes; ++i) {
>             const nsAttrName& name = elem->mAttributes[i].mName;
>-            if (!name.IsAtom())
>+            if (!name.IsAtom()) {
>+                NS_CYCLE_COLLECTION_NOTE_EDGE_NAME(cb, "mAttributes[i]");
Could this be "mAttributes[i].mName.NodeInfo()"
Attachment #590620 - Flags: review?(bugs) → review+
(In reply to Olli Pettay [:smaug] from comment #3)
> Could this be "mAttributes[i].mName.NodeInfo()"
Sounds fine to me.

Putting it on try server in case of weirdness: https://tbpl.mozilla.org/?tree=Try&rev=a1e4ce92b747
https://hg.mozilla.org/mozilla-central/rev/56ee4d79fd79
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.