720325 - GeckoSmsManager is missing serialVersionUIDs

Status: RESOLVED FIXED

(Core :: General, defect, P2)

Description

[Gian-Carlo Pascutto [:gcp]]

There's a whole bunch of those:

/home/morbo/hg/mozilla-central/mobile/android/base/GeckoSmsManager.java:583: warning: [serial] serializable class IdTooHighException has no definition of serialVersionUID
    class IdTooHighException extends Exception { }

They're warnings, not errors. But given that this is currently *the only thing* in the entire project that's spamming warnings, fixing it would be appreciated.

Comment 1

[Lucas Rocha (:lucasr)]

I'm not seeing those warnings anymore. Closing.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

That's because the feature was disabled be default. You'd see them again if you enable it.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: add serialVersionUID for serializable WebSMS exception classes

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Blocking bug 742790 for it has to be verified with WebSMS Android backend.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 674174 [details] [diff] [review]
add serialVersionUID for serializable WebSMS exception classes

Review of attachment 674174 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoSmsManager.java
@@ +883,5 @@
>      MessagesListManager.getInstance().clear();
>    }
> +
> +  class IdTooHighException extends Exception {
> +    private static final long serialVersionUID = 1L;

what is serialVersionUID for?

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Brad Lassey [:blassey] from comment #5)
> Comment on attachment 674174 [details] [diff] [review]
> add serialVersionUID for serializable WebSMS exception classes
> 
> Review of attachment 674174 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/GeckoSmsManager.java
> @@ +883,5 @@
> >      MessagesListManager.getInstance().clear();
> >    }
> > +
> > +  class IdTooHighException extends Exception {
> > +    private static final long serialVersionUID = 1L;
> 
> what is serialVersionUID for?

nevermind, read up on it. If we're going to define these, let's at least make them unique.

Comment 7

[Vicamo Yang [:vicamo][:vyang]]

Attachment: V2

Randomize serialVersionUID. Addressed review comment #6.

Comment 8

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/164d7dd54ee0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/164d7dd54ee0