GeckoSmsManager is missing serialVersionUIDs

RESOLVED FIXED in mozilla19

Status

()

defect
P2
normal
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: gcp, Assigned: vicamo)

Tracking

Trunk
mozilla19
ARM
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

There's a whole bunch of those:

/home/morbo/hg/mozilla-central/mobile/android/base/GeckoSmsManager.java:583: warning: [serial] serializable class IdTooHighException has no definition of serialVersionUID
    class IdTooHighException extends Exception { }

They're warnings, not errors. But given that this is currently *the only thing* in the entire project that's spamming warnings, fixing it would be appreciated.
Assignee: nobody → lucasr.at.mozilla
tracking-fennec: --- → 11+
Priority: -- → P2
I'm not seeing those warnings anymore. Closing.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
That's because the feature was disabled be default. You'd see them again if you enable it.
Assignee: lucasr.at.mozilla → nobody
Blocks: websms
Status: RESOLVED → REOPENED
Product: Fennec Native → Core
QA Contact: general → general
Resolution: WORKSFORME → ---
Status: REOPENED → NEW
tracking-fennec: 11+ → ?
Assignee: nobody → vyang
Blocking bug 742790 for it has to be verified with WebSMS Android backend.
Blocks: 742790
Comment on attachment 674174 [details] [diff] [review]
add serialVersionUID for serializable WebSMS exception classes

Review of attachment 674174 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoSmsManager.java
@@ +883,5 @@
>      MessagesListManager.getInstance().clear();
>    }
> +
> +  class IdTooHighException extends Exception {
> +    private static final long serialVersionUID = 1L;

what is serialVersionUID for?
(In reply to Brad Lassey [:blassey] from comment #5)
> Comment on attachment 674174 [details] [diff] [review]
> add serialVersionUID for serializable WebSMS exception classes
> 
> Review of attachment 674174 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/GeckoSmsManager.java
> @@ +883,5 @@
> >      MessagesListManager.getInstance().clear();
> >    }
> > +
> > +  class IdTooHighException extends Exception {
> > +    private static final long serialVersionUID = 1L;
> 
> what is serialVersionUID for?

nevermind, read up on it. If we're going to define these, let's at least make them unique.
Attachment #674174 - Flags: review?(blassey.bugs) → review-
Posted patch V2Splinter Review
Randomize serialVersionUID. Addressed review comment #6.
Attachment #674174 - Attachment is obsolete: true
Attachment #674562 - Flags: review?(blassey.bugs)
Attachment #674562 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/164d7dd54ee0
Status: NEW → RESOLVED
Closed: 8 years ago7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla19
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.