Drop unused MSG_FASTER_URI_PARSING code

RESOLVED FIXED in Thunderbird 12.0

Status

MailNews Core
Backend
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: aceman)

Tracking

Trunk
Thunderbird 12.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
No functional change, just drop some unused code that we've never used. See the url for details.

It also gets rid of a static nsCOMPtr instance, that although its unused, shouldn't be there anyway (bug 467356).

Aceman, want to pick this up?
(Assignee)

Comment 1

5 years ago
If I understand this correctly, the code is ifdefed in MSG_FASTER_URI_PARSING, but that is newer defined, so the code is dead. If that is true then I can take this.

But I do not understand the relation to bug 467356. Should I wait on that bug to get resolved first? Or with I actually do part of the work that bug 467356 should have done?
Assignee: nobody → acelists
(Reporter)

Comment 2

5 years ago
(In reply to :aceman from comment #1)
> If I understand this correctly, the code is ifdefed in
> MSG_FASTER_URI_PARSING, but that is newer defined, so the code is dead. If
> that is true then I can take this.

Correct.

> But I do not understand the relation to bug 467356. Should I wait on that
> bug to get resolved first? Or with I actually do part of the work that bug
> 467356 should have done?

You're doing part of the work that bug 467356 would have done.
(Assignee)

Comment 3

5 years ago
Created attachment 590833 [details] [diff] [review]
patch
Attachment #590833 - Flags: review?(mbanner)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Reporter)

Updated

5 years ago
Attachment #590833 - Flags: review?(mbanner) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Reporter)

Comment 4

5 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/d58e5898881d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
You need to log in before you can comment on or make changes to this bug.