Last Comment Bug 720354 - Drop unused MSG_FASTER_URI_PARSING code
: Drop unused MSG_FASTER_URI_PARSING code
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Backend (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 12.0
Assigned To: :aceman
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on:
Blocks: 467356
  Show dependency treegraph
 
Reported: 2012-01-23 06:19 PST by Mark Banner (:standard8)
Modified: 2012-01-27 06:28 PST (History)
3 users (show)
standard8: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (3.76 KB, patch)
2012-01-23 12:54 PST, :aceman
standard8: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8) 2012-01-23 06:19:10 PST
No functional change, just drop some unused code that we've never used. See the url for details.

It also gets rid of a static nsCOMPtr instance, that although its unused, shouldn't be there anyway (bug 467356).

Aceman, want to pick this up?
Comment 1 :aceman 2012-01-23 06:48:38 PST
If I understand this correctly, the code is ifdefed in MSG_FASTER_URI_PARSING, but that is newer defined, so the code is dead. If that is true then I can take this.

But I do not understand the relation to bug 467356. Should I wait on that bug to get resolved first? Or with I actually do part of the work that bug 467356 should have done?
Comment 2 Mark Banner (:standard8) 2012-01-23 07:10:23 PST
(In reply to :aceman from comment #1)
> If I understand this correctly, the code is ifdefed in
> MSG_FASTER_URI_PARSING, but that is newer defined, so the code is dead. If
> that is true then I can take this.

Correct.

> But I do not understand the relation to bug 467356. Should I wait on that
> bug to get resolved first? Or with I actually do part of the work that bug
> 467356 should have done?

You're doing part of the work that bug 467356 would have done.
Comment 3 :aceman 2012-01-23 12:54:38 PST
Created attachment 590833 [details] [diff] [review]
patch
Comment 4 Mark Banner (:standard8) 2012-01-27 06:28:23 PST
Checked in: http://hg.mozilla.org/comm-central/rev/d58e5898881d

Note You need to log in before you can comment on or make changes to this bug.