Closed
Bug 720427
Opened 14 years ago
Closed 14 years ago
Save as pdf not working on .txt files
Categories
(Firefox for Android Graveyard :: General, defect, P3)
Tracking
(firefox11 verified, firefox12 verified, fennec+)
VERIFIED
FIXED
People
(Reporter: fredy, Assigned: Margaret)
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
wesj
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build ID: 20111220165912
Steps to reproduce:
Mozilla/5.0 (Android; Linux armv7I; rv:11.0a2) Gecko/20120122 Firefox/11.0a2 Fennec/11.0a2
Mozilla/5.0 (Android; Linux armv7I; rv:12.0a1) Gecko/20120122 Firefox/12.0a1 Fennec/12.0a1
Android Version: 2.3.7
1. Go at url of .txt file (e.g. http://www.gutenberg.org/cache/epub/8800/pg8800.txt)
2. Choose "Save as PDF"
Actual results:
It should generate and download the .txt as a pdf file.
Expected results:
It doesn't generate and download the .txt as a pdf file.
Comment 1•14 years ago
|
||
@margaret; is content-type: text/plain accepted to work with Save as PDF?
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Assignee | ||
Comment 2•14 years ago
|
||
I'm seeing this error:
GeckoConsole: [JavaScript Error: "aURI is undefined" {file: "chrome://global/content/contentAreaUtils.js" line: 870}]
It looks like we're failing to get a documentURI here: http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#537.
I think we just need to use some fallback if we don't have a good URI.
Updated•14 years ago
|
Assignee: nobody → margaret.leibovic
tracking-fennec: --- → +
Priority: -- → P3
| Assignee | ||
Comment 3•14 years ago
|
||
aBrowser.documentURI doesn't exist - we should be using aBrowser.currentURI. I guess we never noticed this before because we've only been testing on pages with titles, but this will fix that now.
Attachment #590994 -
Flags: review?(wjohnston)
Updated•14 years ago
|
Attachment #590994 -
Flags: review?(wjohnston) → review+
| Assignee | ||
Comment 4•14 years ago
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Version: Firefox 11 → Firefox 12
| Assignee | ||
Comment 6•14 years ago
|
||
Comment on attachment 590994 [details] [diff] [review]
patch
[Approval Request Comment]
Fixes Save as PDF for webpages without titles, which is totally busted without this. Landed on m-c this morning, so it will be in Nightly tomorrow.
Attachment #590994 -
Flags: approval-mozilla-aurora?
Comment 7•14 years ago
|
||
Comment on attachment 590994 [details] [diff] [review]
patch
[Triage Comment]
Mobile only - approved for Aurora.
Attachment #590994 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
| Assignee | ||
Comment 8•14 years ago
|
||
status-firefox11:
--- → fixed
status-firefox12:
--- → fixed
Comment 9•14 years ago
|
||
Verified fixed on:
Aurora: Mozilla /5.0 (Android;Linux armv7l;rv:11.0a2) Gecko/20120131 Firefox/11.0a2 Fennec/11.0a2
Nightly: Mozilla /5.0 (Android;Linux armv7l;rv:12.0a1) Gecko/20120201 Firefox/12.0a1 Fennec/12.0a1
Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
| Reporter | ||
Comment 10•14 years ago
|
||
I verify also that works fine now.
Thanks everyone for the quick response and resolve.
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•