The default bug view has changed. See this FAQ.

Crash in profile migration NumberFormatException [@ PlacesTask.migrateHistory]

RESOLVED FIXED

Status

()

Firefox for Android
General
P2
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mbrubeck, Assigned: gcp)

Tracking

({crash})

12 Branch
ARM
Android
crash
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec11+)

Details

(Whiteboard: [native-crash], crash signature)

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
This happened after I installed a local Native build from mozilla-central tip over a local XUL build  from mozilla-central tip:

I/GeckoApp( 5560): start
I/GeckoApp( 5560): resume
W/GeckoApp( 5560): zerdatime 169956483 - pre checkLaunchState
I/GeckoApp( 5560): Checking for an update
W/GeckoApp( 5560): checking for an update took 0ms
I/GeckoDirProvider( 5560): Get profile dir for default
I/GeckoApp( 5560): checking profile migration in: /data/data/org.mozilla.fennec_mbrubeck/files/mozilla/cpll84wf.default
I/ProfMigr( 5560): Opening path: /data/data/org.mozilla.fennec_mbrubeck/files/mozilla/cpll84wf.default/places.sqlite
I/dalvikvm( 5560): Could not find method android.database.sqlite.SQLiteDatabase.enableWriteAheadLogging, referenced from method org.mozilla.fennec_mbrubeck.db.BrowserProvider$DatabaseHelper.onOpen
W/dalvikvm( 5560): VFY: unable to resolve virtual method 222: Landroid/database/sqlite/SQLiteDatabase;.enableWriteAheadLogging ()Z
I/GeckoDirProvider( 5560): Get profile dir for default
W/dalvikvm( 5560): threadid=9: thread exiting with uncaught exception (group=0x40015578)
E/AndroidRuntime( 5560): FATAL EXCEPTION: GeckoLooper Thread
E/AndroidRuntime( 5560): java.lang.NumberFormatException
E/AndroidRuntime( 5560): 	at java.lang.Long.parseLong(Long.java:333)
E/AndroidRuntime( 5560): 	at java.lang.Long.parseLong(Long.java:311)
E/AndroidRuntime( 5560): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.migrateHistory(ProfileMigrator.java:186)
E/AndroidRuntime( 5560): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.migratePlaces(ProfileMigrator.java:281)
E/AndroidRuntime( 5560): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.run(ProfileMigrator.java:316)
E/AndroidRuntime( 5560): 	at android.os.Handler.handleCallback(Handler.java:587)
E/AndroidRuntime( 5560): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime( 5560): 	at android.os.Looper.loop(Looper.java:130)
E/AndroidRuntime( 5560): 	at org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:174)
W/ActivityManager(  113):   Force finishing activity org.mozilla.fennec_mbrubeck/.App
Assignee: nobody → gpascutto
tracking-fennec: ? → 11+
Priority: -- → P2
(Assignee)

Comment 1

5 years ago
If your places.sqlite doesn't contain anything private, can you attach it to this bug?
(Reporter)

Comment 2

5 years ago
Created attachment 590925 [details]
places.sqlite.bz2

I was able to reproduce this in a brand new profile with these steps, on 7" Galaxy Tab (Android 2.3):

1. Install XUL Fennec build from mozilla-central tip.
2. Use "Clear data" in the Android Settings app to remove any profile data.
3. Launch Fennec.
4. Quit Fennec.
5. Install Native Fennec build from mozilla-central tip.
6. Launch Fennec.
7. Crash!

The places.sqlite file is attached (bzip2ed).

Updated

5 years ago
Whiteboard: [native-crash]
(Assignee)

Comment 3

5 years ago
Created attachment 591079 [details] [diff] [review]
Patch 1. Fix loop logic in SQLiteBridge

We still return a row with nulls even if the result set is empty.
Attachment #591079 - Flags: review?(doug.turner)
(Assignee)

Comment 4

5 years ago
Comment on attachment 591079 [details] [diff] [review]
Patch 1. Fix loop logic in SQLiteBridge

[Approval Request Comment]
Should go together with bug 713228.
Attachment #591079 - Flags: approval-mozilla-aurora?

Updated

5 years ago
status-firefox11: --- → affected

Updated

5 years ago
Attachment #591079 - Flags: review?(doug.turner)
Attachment #591079 - Flags: review+
Attachment #591079 - Flags: approval-mozilla-aurora?
Attachment #591079 - Flags: approval-mozilla-aurora+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/08917f31c6ab
https://hg.mozilla.org/mozilla-central/rev/08917f31c6ab
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/62fc7d5a3085
Status: RESOLVED → REOPENED
status-firefox11: affected → fixed
status-firefox12: affected → fixed
Resolution: FIXED → ---
Target Milestone: Firefox 12 → ---
(Assignee)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.