720461 - Crash in profile migration NumberFormatException [@ PlacesTask.migrateHistory]

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Matt Brubeck (:mbrubeck)]

This happened after I installed a local Native build from mozilla-central tip over a local XUL build  from mozilla-central tip:

I/GeckoApp( 5560): start
I/GeckoApp( 5560): resume
W/GeckoApp( 5560): zerdatime 169956483 - pre checkLaunchState
I/GeckoApp( 5560): Checking for an update
W/GeckoApp( 5560): checking for an update took 0ms
I/GeckoDirProvider( 5560): Get profile dir for default
I/GeckoApp( 5560): checking profile migration in: /data/data/org.mozilla.fennec_mbrubeck/files/mozilla/cpll84wf.default
I/ProfMigr( 5560): Opening path: /data/data/org.mozilla.fennec_mbrubeck/files/mozilla/cpll84wf.default/places.sqlite
I/dalvikvm( 5560): Could not find method android.database.sqlite.SQLiteDatabase.enableWriteAheadLogging, referenced from method org.mozilla.fennec_mbrubeck.db.BrowserProvider$DatabaseHelper.onOpen
W/dalvikvm( 5560): VFY: unable to resolve virtual method 222: Landroid/database/sqlite/SQLiteDatabase;.enableWriteAheadLogging ()Z
I/GeckoDirProvider( 5560): Get profile dir for default
W/dalvikvm( 5560): threadid=9: thread exiting with uncaught exception (group=0x40015578)
E/AndroidRuntime( 5560): FATAL EXCEPTION: GeckoLooper Thread
E/AndroidRuntime( 5560): java.lang.NumberFormatException
E/AndroidRuntime( 5560): 	at java.lang.Long.parseLong(Long.java:333)
E/AndroidRuntime( 5560): 	at java.lang.Long.parseLong(Long.java:311)
E/AndroidRuntime( 5560): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.migrateHistory(ProfileMigrator.java:186)
E/AndroidRuntime( 5560): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.migratePlaces(ProfileMigrator.java:281)
E/AndroidRuntime( 5560): 	at org.mozilla.gecko.ProfileMigrator$PlacesTask.run(ProfileMigrator.java:316)
E/AndroidRuntime( 5560): 	at android.os.Handler.handleCallback(Handler.java:587)
E/AndroidRuntime( 5560): 	at android.os.Handler.dispatchMessage(Handler.java:92)
E/AndroidRuntime( 5560): 	at android.os.Looper.loop(Looper.java:130)
E/AndroidRuntime( 5560): 	at org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:174)
W/ActivityManager(  113):   Force finishing activity org.mozilla.fennec_mbrubeck/.App

Comment 1

[Gian-Carlo Pascutto [:gcp]]

If your places.sqlite doesn't contain anything private, can you attach it to this bug?

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: places.sqlite.bz2

I was able to reproduce this in a brand new profile with these steps, on 7" Galaxy Tab (Android 2.3):

1. Install XUL Fennec build from mozilla-central tip.
2. Use "Clear data" in the Android Settings app to remove any profile data.
3. Launch Fennec.
4. Quit Fennec.
5. Install Native Fennec build from mozilla-central tip.
6. Launch Fennec.
7. Crash!

The places.sqlite file is attached (bzip2ed).

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Attachment: Patch 1. Fix loop logic in SQLiteBridge

We still return a row with nulls even if the result set is empty.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 591079 [details] [diff] [review]
Patch 1. Fix loop logic in SQLiteBridge

[Approval Request Comment]
Should go together with bug 713228.

Comment 5

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/08917f31c6ab

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/08917f31c6ab

Comment 7

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/62fc7d5a3085