720494 - Move GeckoApp.handleAddTab logic into Tabs.addTab

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[:Margaret Leibovic]

Attachment: patch

This patch just cleans up the code a little. I also added some logging with timestamps so that we can time this message path (as suggested in bug 719493 comment 7).

Fixing slowness in this loop would help us fix bug 718465.

Comment 1

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9be58af4f6a5

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/9be58af4f6a5

Comment 3

[:Margaret Leibovic]

Comment on attachment 590851 [details] [diff] [review]
patch

[Approval Request Comment]
Cleans up code and adds some logging. We'll probably write patches on top of this, so it would be good to be in Aurora to prevent conflicts. Landed on m-c this morning, so it will be in Nightly tomorrow.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Last time I checked, code cleanup was well on the not-approvable side.

Comment 5

[:Margaret Leibovic]

(In reply to Ms2ger from comment #4)
> Last time I checked, code cleanup was well on the not-approvable side.

Mobile has different approval requirements. Because we're landing the majority of the patches we write on aurora, we've also been landing bugs like this to prevent conflicts when trying to land future patches. We could wait until that conflict comes up and track down this patch then, but IMO it's easier to just land a low-risk patch like this, especially since a patch for bug 718465 would probably depend on this.

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 590851 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8a381c459787