The default bug view has changed. See this FAQ.

Move GeckoApp.handleAddTab logic into Tabs.addTab

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P4
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

Trunk
Firefox 12
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec+)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 590851 [details] [diff] [review]
patch

This patch just cleans up the code a little. I also added some logging with timestamps so that we can time this message path (as suggested in bug 719493 comment 7).

Fixing slowness in this loop would help us fix bug 718465.
Attachment #590851 - Flags: review?(mbrubeck)
Attachment #590851 - Flags: review?(mbrubeck) → review+
(Assignee)

Updated

5 years ago
Assignee: nobody → margaret.leibovic
tracking-fennec: --- → +
Priority: -- → P4
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9be58af4f6a5
https://hg.mozilla.org/mozilla-central/rev/9be58af4f6a5
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
(Assignee)

Comment 3

5 years ago
Comment on attachment 590851 [details] [diff] [review]
patch

[Approval Request Comment]
Cleans up code and adds some logging. We'll probably write patches on top of this, so it would be good to be in Aurora to prevent conflicts. Landed on m-c this morning, so it will be in Nightly tomorrow.
Attachment #590851 - Flags: approval-mozilla-aurora?
Last time I checked, code cleanup was well on the not-approvable side.
(Assignee)

Comment 5

5 years ago
(In reply to Ms2ger from comment #4)
> Last time I checked, code cleanup was well on the not-approvable side.

Mobile has different approval requirements. Because we're landing the majority of the patches we write on aurora, we've also been landing bugs like this to prevent conflicts when trying to land future patches. We could wait until that conflict comes up and track down this patch then, but IMO it's easier to just land a low-risk patch like this, especially since a patch for bug 718465 would probably depend on this.

Comment 6

5 years ago
Comment on attachment 590851 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #590851 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/8a381c459787
status-firefox11: --- → fixed
status-firefox12: --- → fixed
You need to log in before you can comment on or make changes to this bug.