720509 - java.lang.NullPointerException at org.mozilla.gecko.GeckoApp.onPrepareOptionsMenu(GeckoApp.java:487)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

From Socorro:

248 Crash count for :

EGL? EGL+
AdapterVendorID: herring, AdapterDeviceID: Nexus S.
AdapterDescription: 'Android, Model: 'Nexus S', Product: 'soju', Manufacturer: 'samsung', Hardware: 'herring''.
java.lang.NullPointerException
	at org.mozilla.gecko.GeckoApp.onPrepareOptionsMenu(GeckoApp.java:487)
	at android.app.Activity.onPreparePanel(Activity.java:2462)
	at com.android.internal.policy.impl.PhoneWindow.preparePanel(PhoneWindow.java:416)
	at com.android.internal.policy.impl.PhoneWindow.onKeyDownPanel(PhoneWindow.java:759)
	at com.android.internal.policy.impl.PhoneWindow.onKeyDown(PhoneWindow.java:1424)
	at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchKeyEvent(PhoneWindow.java:1813)
	at android.view.ViewRootImpl.deliverKeyEventPostIme(ViewRootImpl.java:3327)
	at android.view.ViewRootImpl.handleFinishedEvent(ViewRootImpl.java:3300)
	at android.view.ViewRootImpl.handleMessage(ViewRootImpl.java:2460)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.lo

473171f1-46a3-4070-8ded-57f882111230
64ec9ff8-89f6-4ceb-814d-8ade22111229
bd9361b3-41ea-4bf8-952e-b3f802120111
c7554b7d-b65c-4a01-816c-a74d42120109


https://crash-stats.mozilla.com/report/index/47bae3e8-abc1-497c-a93c-0fa8e2111225

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Java signature.  It's hard to tell what's going on without getting a socorro report

Comment 2

[Scoobidiver (away)]

Here are crash reports:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A%20at%20org.mozilla.gecko.GeckoApp.onPrepareOptionsMenu%28GeckoApp.java%29

Comment 3

[Ioana Chiorean]

Steps to reproduce:
1. Open new tab
2. Write anything (ex. mozillane..)
3. Do a Search - press the magnifying glass button
4. Press Menu buttons

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Nice work, Ioana!

Comment 5

[Brian Nicholson (:bnicholson)]

Attachment: patch

When doing a search "foo" in the AwesomeScreen, the tab URL gets set to "foo" before being resolved to a URL. Since this isn't an actual URL, getScheme() will be null.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 595466 [details] [diff] [review]
patch

hmm, can we try to fix the Tab.getURL to not get set to anything but a URL. I am a little worried that we have a non-URL in the URL field. Could be trouble in other areas of the code.

r+ on this for now

Comment 7

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/331973a3884e

Comment 8

[Brian Nicholson (:bnicholson)]

(In reply to Mark Finkle (:mfinkle) from comment #6)
> Comment on attachment 595466 [details] [diff] [review]
> patch
> 
> hmm, can we try to fix the Tab.getURL to not get set to anything but a URL.
> I am a little worried that we have a non-URL in the URL field. Could be
> trouble in other areas of the code.
> 
> r+ on this for now

Filed bug 726080.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/331973a3884e

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 595466 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 11

[Justin Wood (:Callek)]

Comment on attachment 595466 [details] [diff] [review]
patch

clearing beta approval per akeybl on IRC, No Fennec Native Shipping for Gecko 11