720511 - arr.join("") doesn't always let indexed properties on the prototype show through

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch with tests

Nitpicky spec compliance issue, noticed in passing while reading other code.

Comment 1

[Luke Wagner [:luke]]

Comment on attachment 590870 [details] [diff] [review]
Patch with tests

>+        const Value *iter;

'iter' is often the name for the iterator object so I was a bit confused when I first looked at the code.  How about 'elem'?

>+            if (iter->isObject())
>+                break;

Could you prefix this with a short comment about why the test is necessary?

Comment 2

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5fcbfafa4471

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5fcbfafa4471

Comment 4

[Jeff Walden [:Waldo]]

Okay, this is kind of ridiculous, but I did some searching, and I actually found a site which breaks because of join("") not exposing prototyped properties.  (I know, right?)  I talked to akeybl about it, and he was okay taking this on aurora, so I landed it there:

https://hg.mozilla.org/releases/mozilla-aurora/rev/1a931c313611

The things the web does, srsly...

Comment 5

[Jean-Yves Perrier [:teoli]]

Aurora is Fx11 right now? Shouldn't we change the target date?

Comment 6

[Jeff Walden [:Waldo]]

Doesn't hurt to change it, no, I guess.  Version numbering in bugs is a bit fuzzy, and arguably setting the version and all that, given that we have multiple versions in flight at once, is mostly an attractive nuisance.

Notwithstanding comment 4, I doubt we need to document this.  And I doubt that even if we did document it, the people who would be affected by this bug would read our documentation such that they'd benefit from an improvement in this regard.