Closed
Bug 720559
Opened 13 years ago
Closed 13 years ago
IonMonkey: Cannot compile functions with JSOP_THIS using OSR.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sstangl, Assigned: dvander)
Details
Attachments
(2 files)
|
271 bytes,
application/javascript
|
Details | |
|
1.34 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
IonBuilder::jsop_this() fails compilation if thisParam is not of type Object, but in the case of OSR, the parameter is a Value-typed MPhi. This hurts us on several benchmarks, notably access-nbody.
|
Assignee | |
Comment 1•13 years ago
|
||
The problem is that we don't type phis until type analysis - more evidence that, even when it's safe, we shouldn't rely on MIR types during building. This is a quick fix that I think is correct: just query the initial type from TI.
(This brings our kraken-ai-astar score from 14000ms to 263, close to crankshaft - more work needed to get to -m -n speed.)
|
||
Updated•13 years ago
|
Attachment #592355 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•