720574 - Remove unused variables and imports

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[:Margaret Leibovic]

Attachment: patch

I didn't go through every file, but this fixes the unused variable/import warnings I've come across in Eclipse. I can give it a try server run to make sure it doesn't break anything.

Comment 1

[Matt Brubeck (:mbrubeck)]

Comment on attachment 590939 [details] [diff] [review]
patch

>         public AwesomeBarCursorAdapter(Context context, int layout, Cursor c, String[] from, int[] to) {
>             super(context, layout, c, from, to);
>-            mLayout = layout;
>-            mTo = to;
>-            mFrom = from;
>-            mSearchTerm = "";
>         }

The "mSearchTerm" change here is the only one that seemed potentially bad.  Even if it's not currently necessary, I'd rather initialize it here than risk that some current or future code uses it unitialized.

r=mbrubeck except for that change.

Comment 2

[:Margaret Leibovic]

(In reply to Matt Brubeck (:mbrubeck) from comment #1)
> >         public AwesomeBarCursorAdapter(Context context, int layout, Cursor c, String[] from, int[] to) {
> >             super(context, layout, c, from, to);
> >-            mLayout = layout;
> >-            mTo = to;
> >-            mFrom = from;
> >-            mSearchTerm = "";
> >         }
> 
> The "mSearchTerm" change here is the only one that seemed potentially bad. 
> Even if it's not currently necessary, I'd rather initialize it here than
> risk that some current or future code uses it unitialized.

Oops, I accidentally deleted that. To be clear, you're okay with the other variables being removed there, just not mSearchTerm?

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to Margaret Leibovic [:margaret] from comment #2)
> > The "mSearchTerm" change here is the only one that seemed potentially bad.
> 
> Oops, I accidentally deleted that. To be clear, you're okay with the other
> variables being removed there, just not mSearchTerm?

Right.

Comment 4

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c375946d5039

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/c375946d5039

Comment 6

[:Margaret Leibovic]

Comment on attachment 590939 [details] [diff] [review]
patch

[Approval Request Comment]
Code clean-up. It would be good to get this into Aurora to prevent conflicts. Landed on m-c this morning, so it will be in Nightly tomorrow.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 590939 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/0fdbeccb55af