Closed Bug 720574 Opened 8 years ago Closed 8 years ago

Remove unused variables and imports

Categories

(Firefox for Android :: General, defect, P4)

ARM
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 12
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: Margaret, Assigned: Margaret)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
I didn't go through every file, but this fixes the unused variable/import warnings I've come across in Eclipse. I can give it a try server run to make sure it doesn't break anything.
Attachment #590939 - Flags: review?(mbrubeck)
Comment on attachment 590939 [details] [diff] [review]
patch

>         public AwesomeBarCursorAdapter(Context context, int layout, Cursor c, String[] from, int[] to) {
>             super(context, layout, c, from, to);
>-            mLayout = layout;
>-            mTo = to;
>-            mFrom = from;
>-            mSearchTerm = "";
>         }

The "mSearchTerm" change here is the only one that seemed potentially bad.  Even if it's not currently necessary, I'd rather initialize it here than risk that some current or future code uses it unitialized.

r=mbrubeck except for that change.
Attachment #590939 - Flags: review?(mbrubeck) → review+
(In reply to Matt Brubeck (:mbrubeck) from comment #1)
> >         public AwesomeBarCursorAdapter(Context context, int layout, Cursor c, String[] from, int[] to) {
> >             super(context, layout, c, from, to);
> >-            mLayout = layout;
> >-            mTo = to;
> >-            mFrom = from;
> >-            mSearchTerm = "";
> >         }
> 
> The "mSearchTerm" change here is the only one that seemed potentially bad. 
> Even if it's not currently necessary, I'd rather initialize it here than
> risk that some current or future code uses it unitialized.

Oops, I accidentally deleted that. To be clear, you're okay with the other variables being removed there, just not mSearchTerm?
(In reply to Margaret Leibovic [:margaret] from comment #2)
> > The "mSearchTerm" change here is the only one that seemed potentially bad.
> 
> Oops, I accidentally deleted that. To be clear, you're okay with the other
> variables being removed there, just not mSearchTerm?

Right.
tracking-fennec: --- → 11+
Priority: -- → P4
https://hg.mozilla.org/mozilla-central/rev/c375946d5039
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 590939 [details] [diff] [review]
patch

[Approval Request Comment]
Code clean-up. It would be good to get this into Aurora to prevent conflicts. Landed on m-c this morning, so it will be in Nightly tomorrow.
Attachment #590939 - Flags: approval-mozilla-aurora?
Comment on attachment 590939 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #590939 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.