720623 - Get rid of nsHTMLFormatConverter and nsIFormatConverter

Status: NEW

(Core :: DOM: Serializers, enhancement, P5)

Description

[Henri Sivonen (:hsivonen)]

It looks like nsHTMLFormatConverter and nsIFormatConverter are excessive abstraction and architecture. Callers could be adapted to call nsContentUtils::ConvertToPlainText with the appropriate flags once bug 650784 has landed.

Comment 1

[Ben Bucksch (:BenB)]

Did you check how many extensions use this? Myself, I have not seen this being used ever, it's the first time I see this, IIRC. I think people simply didn't *find* it as the API to nsPlaintextConverter and thus didn't use it, so a simple comment in the right place would do wonders.

Personally, I don't think it's such a bad idea, though. I'd just combine getInputDataFlavors(); getOutputDataFlavors(); boolean canConvert(..); into getConversionMimetypes() which returns a single list of "ab/dc; e=f|gh/ij; k=l" (from|to).

But I can see why you would prefer a single ConvertHTMLToTXT() function. It's much easier to implement and to use by extensions.

Comment 2

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=5 years untouched DOM/Storage bugs' priority.

If you have reason to believe this is wrong (especially for the severity), please write a comment and ni :jstutte.

Comment 3

[Harshit Sohaney [:hsohaney]]

Is this bug still relevant? I see these being used throughout the codebase

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to Harshit Sohaney [:hsohaney] from comment #3)

Is this bug still relevant? I see these being used throughout the codebase

This is still relevant. I see very few callers. What Searchfox query are you using?

Comment 5

[Harshit Sohaney [:hsohaney]]

(In reply to Henri Sivonen (:hsivonen) from comment #4)

(In reply to Harshit Sohaney [:hsohaney] from comment #3)

Is this bug still relevant? I see these being used throughout the codebase

This is still relevant. I see very few callers. What Searchfox query are you using?

I just searched for the interfaces, looks like theres only a few. Was just checking if this is still good. Our university keeps a track of good first bugs for Firefox, I'll go ahead and add this onto that!