Last Comment Bug 720628 - Improve error reporting of Promise.jsm
: Improve error reporting of Promise.jsm
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: unspecified
: All All
: -- enhancement (vote)
: mozilla14
Assigned To: David Rajchenbach-Teller [:Yoric] (please use "needinfo")
:
Mentors:
Depends on:
Blocks: JSScheduleAPI 711126 735477
  Show dependency treegraph
 
Reported: 2012-01-24 01:01 PST by David Rajchenbach-Teller [:Yoric] (please use "needinfo")
Modified: 2012-03-15 08:18 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Better error reporting (3.31 KB, patch)
2012-01-24 01:49 PST, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
jwalker: review+
Details | Diff | Review
Better error reporting (6.32 KB, patch)
2012-02-24 07:03 PST, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
rcampbell: review+
Details | Diff | Review
Better error reporting (5.29 KB, patch)
2012-03-07 07:24 PST, David Rajchenbach-Teller [:Yoric] (please use "needinfo")
no flags Details | Diff | Review

Description David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-01-24 01:01:14 PST
At the moment, in many cases, Promise.jsm causes silent dropping of exceptions. Let's fix this.
Comment 1 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-01-24 01:49:23 PST
Created attachment 591035 [details] [diff] [review]
Better error reporting

Sorry for the snafu, this time the patch is attached to the correct bug
Comment 2 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-02-24 07:03:59 PST
Created attachment 600383 [details] [diff] [review]
Better error reporting

Attaching a version of this patch that uses function |Promise._error| introduced in bug 711126.
Comment 3 David Rajchenbach-Teller [:Yoric] (please use "needinfo") 2012-03-07 07:24:41 PST
Created attachment 603715 [details] [diff] [review]
Better error reporting

Run a few additional tests on dependent libraries, found an error. Here is the same patch, without the error.
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-03-14 15:03:42 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/41d14a8398a2
Comment 5 Marco Bonardo [::mak] 2012-03-15 08:18:38 PDT
https://hg.mozilla.org/mozilla-central/rev/41d14a8398a2

Note You need to log in before you can comment on or make changes to this bug.