Closed Bug 720628 Opened 13 years ago Closed 13 years ago

Improve error reporting of Promise.jsm

Categories

(Core :: General, enhancement)

Product:
Core
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: Yoric, Assigned: Yoric)

References

Details

Attachments

(1 file, 2 obsolete files)

Better error reporting
5.29 KB, patch
Details | Diff | Splinter Review
At the moment, in many cases, Promise.jsm causes silent dropping of exceptions. Let's fix this.
Attached patch Better error reporting (obsolete) — — Splinter Review
Sorry for the snafu, this time the patch is attached to the correct bug
Attachment #591035 - Flags: review?(jwalker)
Attachment #591035 - Flags: review?(jwalker) → review+
Depends on: 711126
Attached patch Better error reporting (obsolete) — — Splinter Review
Attaching a version of this patch that uses function |Promise._error| introduced in bug 711126.
Attachment #600383 - Flags: review?(rcampbell)
Attachment #591035 - Attachment is obsolete: true
Attachment #600383 - Flags: review?(rcampbell) → review?(jwalker)
Attachment #600383 - Flags: review?(jwalker) → review+
Run a few additional tests on dependent libraries, found an error. Here is the same patch, without the error.
Attachment #600383 - Attachment is obsolete: true
Blocks: 711126
No longer depends on: 711126
Keywords: checkin-needed
Assignee: nobody → dteller
https://hg.mozilla.org/mozilla-central/rev/41d14a8398a2
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: