Add message managers to black-bit-propagation

RESOLVED FIXED in mozilla12

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

12 Branch
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 591047 [details] [diff] [review]
patch

This code will be used by nsCCUncollectableMarker::Observe.
Attachment #591047 - Flags: review?(continuation)
(Assignee)

Comment 1

5 years ago
Comment on attachment 591047 [details] [diff] [review]
patch

Er, this is only partial patch. Uploading a new one in a minute.
Attachment #591047 - Flags: review?(continuation)
(Assignee)

Comment 2

5 years ago
Comment on attachment 591047 [details] [diff] [review]
patch

Actually this is ok. I'll move some other stuff to nsCCUncollectableMarker
Attachment #591047 - Flags: review?(continuation)
Did you mean to make nsIInProcessContentFrameMessageManager builtinclass? You changed the UUID but didn't do anything else to that class.
Looks reasonable to me, though I still don't like how you are doing the unmark gray on the XPCWrappedJS here. ;)  But let's hash that out in bug 720536.
(Assignee)

Comment 5

5 years ago
(In reply to Andrew McCreight [:mccr8] from comment #3)
> Did you mean to make nsIInProcessContentFrameMessageManager builtinclass?
> You changed the UUID but didn't do anything else to that class.
It isn't a scriptable interface, so builtinclass doesn't really matter, and uuid is changed
by the script which changes uuids in all the interfaces which inherit an interface which got
changed.
Ah, okay, that makes sense.  I figured there was a reason, I just wasn't sure what it was.
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 591047 [details] [diff] [review]
patch

Review of attachment 591047 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you revert the xpcprivate.h include and replace the if block as described below.

::: content/base/src/nsFrameMessageManager.cpp
@@ +1117,5 @@
> +  PRUint32 len = mListeners.Length();
> +  for (PRUint32 i = 0; i < len; ++i) {
> +    nsCOMPtr<nsIXPConnectWrappedJS> wjs =
> +      do_QueryInterface(mListeners[i].mListener);
> +    if (wjs) {

I assume you will replace this whole "if (wjs) { ... }" block with just "xpc_UnmarkGrayObject(wjs);" as per the other bugs.
Attachment #591047 - Flags: review?(continuation) → review+
(Assignee)

Comment 8

5 years ago
Yup. I have that already fixed locally.
(Assignee)

Comment 9

5 years ago
Created attachment 591791 [details] [diff] [review]
patch
Assignee: nobody → bugs
Status: NEW → ASSIGNED
(Assignee)

Comment 10

5 years ago
Created attachment 591796 [details] [diff] [review]
patch
Attachment #591791 - Attachment is obsolete: true
(Assignee)

Comment 11

5 years ago
https://hg.mozilla.org/mozilla-central/rev/85b19db37fd0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.