Closed Bug 720647 Opened 8 years ago Closed 8 years ago

Add message managers to black-bit-propagation

Categories

(Core :: DOM: Core & HTML, defect)

12 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla12

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch patchSplinter Review
This code will be used by nsCCUncollectableMarker::Observe.
Attachment #591047 - Flags: review?(continuation)
Comment on attachment 591047 [details] [diff] [review]
patch

Er, this is only partial patch. Uploading a new one in a minute.
Attachment #591047 - Flags: review?(continuation)
Comment on attachment 591047 [details] [diff] [review]
patch

Actually this is ok. I'll move some other stuff to nsCCUncollectableMarker
Attachment #591047 - Flags: review?(continuation)
Did you mean to make nsIInProcessContentFrameMessageManager builtinclass? You changed the UUID but didn't do anything else to that class.
Looks reasonable to me, though I still don't like how you are doing the unmark gray on the XPCWrappedJS here. ;)  But let's hash that out in bug 720536.
(In reply to Andrew McCreight [:mccr8] from comment #3)
> Did you mean to make nsIInProcessContentFrameMessageManager builtinclass?
> You changed the UUID but didn't do anything else to that class.
It isn't a scriptable interface, so builtinclass doesn't really matter, and uuid is changed
by the script which changes uuids in all the interfaces which inherit an interface which got
changed.
Ah, okay, that makes sense.  I figured there was a reason, I just wasn't sure what it was.
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 591047 [details] [diff] [review]
patch

Review of attachment 591047 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you revert the xpcprivate.h include and replace the if block as described below.

::: content/base/src/nsFrameMessageManager.cpp
@@ +1117,5 @@
> +  PRUint32 len = mListeners.Length();
> +  for (PRUint32 i = 0; i < len; ++i) {
> +    nsCOMPtr<nsIXPConnectWrappedJS> wjs =
> +      do_QueryInterface(mListeners[i].mListener);
> +    if (wjs) {

I assume you will replace this whole "if (wjs) { ... }" block with just "xpc_UnmarkGrayObject(wjs);" as per the other bugs.
Attachment #591047 - Flags: review?(continuation) → review+
Yup. I have that already fixed locally.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → bugs
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
Attachment #591791 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/85b19db37fd0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.