Closed
Bug 720663
Opened 14 years ago
Closed 14 years ago
devicemanagerADB pushDir fallback doesn't always work
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 12
People
(Reporter: cwiiis, Assigned: cwiiis)
Details
Attachments
(1 file)
|
2.59 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
On both my devices, running the reftest-remote target (as described here: https://wiki.mozilla.org/Mobile/Fennec/Android#Reftests) fails due to unzip not being present on the device (or not working). The current devicemanagerADB.py script fails to detect this and bails out, but the fallback path works fine.
| Assignee | ||
Comment 1•14 years ago
|
||
This patch allows me to run reftests locally by making sure the fallback path is always tried before bailing out.
Attachment #591061 -
Flags: review?(gbrown)
Comment 2•14 years ago
|
||
Comment on attachment 591061 [details] [diff] [review]
Fix devicemanagerADB.py pushDir fallback
Review of attachment 591061 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks Chris - that's a good change.
Out of curiosity, what was causing the exception for you?
Attachment #591061 -
Flags: review?(gbrown) → review+
| Assignee | ||
Comment 3•14 years ago
|
||
Not sure what the error was, my python foo isn't good enough and I can't quickly find any documentation for the CalledProcessError object...
That said, I think it was just that the device doesn't have an unzip binary.
Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/63db726e7634
Status: NEW → ASSIGNED
Whiteboard: [inbound]
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 12
Updated•14 years ago
|
Keywords: fennecnative-betablocker
Updated•14 years ago
|
Keywords: fennecnative-betablocker
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•