Add the ability to strip MAR signatures

VERIFIED FIXED in Firefox 12

Status

()

Toolkit
Application Update
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

unspecified
mozilla12
x86_64
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox11 unaffected, firefox12 fixed, firefox13 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Add a new command line argument to the mar program to strip the MAR signature block from a MAR file.  This can be used to repurpose a MAR with a new product information block.  

Also add a command line to override the product information block defaults with specific values.
(Assignee)

Comment 1

6 years ago
Created attachment 591123 [details] [diff] [review]
Ability to strip MAR signatures. Patch v1.
Attachment #591123 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 2

6 years ago
This first patch is for the ability to strip MAR signatures only.

I'll have another patch for the ability to refresh a product information block with new values.
(Assignee)

Comment 3

6 years ago
Created attachment 593181 [details] [diff] [review]
Ability to strip MAR signatures. Patch v2.

Rebased because of added -T option from dependent patch.
Attachment #591123 - Attachment is obsolete: true
Attachment #591123 - Flags: review?(robert.bugzilla)
Attachment #593181 - Flags: review?(robert.bugzilla)
(Assignee)

Comment 4

6 years ago
Created attachment 594005 [details] [diff] [review]
Ability to strip MAR signatures. Patch v3.

- Accidentally removed '-r' condition to break out of loop in patch v2. Fixed.
Attachment #593181 - Attachment is obsolete: true
Attachment #593181 - Flags: review?(robert.bugzilla)
Attachment #594005 - Flags: review?(robert.bugzilla)
Comment on attachment 594005 [details] [diff] [review]
Ability to strip MAR signatures. Patch v3.

Looks good but I didn't dive too deeply into this patch
Attachment #594005 - Flags: review?(robert.bugzilla) → review+
(Assignee)

Updated

5 years ago
Depends on: 728935
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/mozilla-central/rev/ad8fe9d36d16
(Assignee)

Comment 7

5 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/18840d884c97
status-firefox11: --- → unaffected
status-firefox12: --- → fixed
status-firefox13: --- → fixed
Target Milestone: mozilla13 → mozilla12
Whiteboard: [qa-]
(Assignee)

Comment 8

5 years ago
I've used this a lot for repairing various MARs, marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.