Closed Bug 720759 Opened 9 years ago Closed 9 years ago

Windows warning patrol


(Core :: JavaScript Engine, defect)

Windows 7
Not set





(Reporter: Waldo, Assigned: Waldo)



(3 files)

!summon themaid
From the log for js/src/jsutil.h:

user:        Jeff Walden <>
date:        Wed Oct 05 15:21:53 2011 -0700
summary:     Make the guard-object macros, used to ensure a class can't accidentally be constructed only temporarily, JS_FRIEND_API-compatible, since they're being used in friend declarations now.  rs=cdleary/luke, no bug

Gotta do the same thing for mfbt's classes...
Attachment #591170 - Flags: review?(Ms2ger)
First it was one method, then two, then then then.  I drew the line at changing js_TestXMLEquality.  And I think changing JSEqualityOp's not possible now either.  :-\
Attachment #591173 - Flags: review?(Ms2ger)
Comment on attachment 591170 [details] [diff] [review]
The guard object classes need to be exported, if they're going to be used in exported APIs

Review of attachment 591170 [details] [diff] [review]:

Attachment #591170 - Flags: review?(Ms2ger) → review+
Yes, Virginia, MOZ_DELETE works outside of classes too.
Attachment #591176 - Flags: review?(Ms2ger)
Comment on attachment 591173 [details] [diff] [review]
Change a mess of function signatures to take bool*, not JSBool*, all to fix one Windows warning comparing bool to JSBool

Review of attachment 591173 [details] [diff] [review]:

I like.
Attachment #591173 - Flags: review?(Ms2ger) → review+
Comment on attachment 591176 [details] [diff] [review]
Delete EqualStrings(cx, linearStr1, linearStr2, &equal) so everyone has to use the made-for-linear-strings overload

Review of attachment 591176 [details] [diff] [review]:

Sure, if this works.
Attachment #591176 - Flags: review?(Ms2ger) → review+
Backed out for win debug failures: (coalescing means this is the first tbpl push that shopws the failure)
Target Milestone: mozilla12 → ---
Sigh; I wasn't thinking that JS_FRIEND_API expands to an export or an import depending on the user.  I needed MFBT_API instead.  Relanded with that, after doing a Windows debug build with that to verify the fix.
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.