Status

()

defect
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla12
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

!summon themaid
From the log for js/src/jsutil.h:

user:        Jeff Walden <jwalden@mit.edu>
date:        Wed Oct 05 15:21:53 2011 -0700
summary:     Make the guard-object macros, used to ensure a class can't accidentally be constructed only temporarily, JS_FRIEND_API-compatible, since they're being used in friend declarations now.  rs=cdleary/luke, no bug

Gotta do the same thing for mfbt's classes...
Attachment #591170 - Flags: review?(Ms2ger)
First it was one method, then two, then then then.  I drew the line at changing js_TestXMLEquality.  And I think changing JSEqualityOp's not possible now either.  :-\
Attachment #591173 - Flags: review?(Ms2ger)
Comment on attachment 591170 [details] [diff] [review]
The guard object classes need to be exported, if they're going to be used in exported APIs

Review of attachment 591170 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm
Attachment #591170 - Flags: review?(Ms2ger) → review+
Yes, Virginia, MOZ_DELETE works outside of classes too.
Attachment #591176 - Flags: review?(Ms2ger)
Comment on attachment 591173 [details] [diff] [review]
Change a mess of function signatures to take bool*, not JSBool*, all to fix one Windows warning comparing bool to JSBool

Review of attachment 591173 [details] [diff] [review]:
-----------------------------------------------------------------

I like.
Attachment #591173 - Flags: review?(Ms2ger) → review+
Comment on attachment 591176 [details] [diff] [review]
Delete EqualStrings(cx, linearStr1, linearStr2, &equal) so everyone has to use the made-for-linear-strings overload

Review of attachment 591176 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, if this works.
Attachment #591176 - Flags: review?(Ms2ger) → review+
Backed out for win debug failures: (coalescing means this is the first tbpl push that shopws the failure)
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=b7f926cfa8c8
https://tbpl.mozilla.org/php/getParsedLog.php?id=8796111&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/cac3f64d36d0
Target Milestone: mozilla12 → ---
Sigh; I wasn't thinking that JS_FRIEND_API expands to an export or an import depending on the user.  I needed MFBT_API instead.  Relanded with that, after doing a Windows debug build with that to verify the fix.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec9a6b8c81d8
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d572733c31e
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd742da19c52
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.