720761 - The bump of the version on default for a release triggers dependent builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

When the bump lands [1] on default it triggers a bunch of dependent builds [2]

The commit message looks like this:
"Automated checkin: version bump for firefox 3.6.26 release. CLOSED TREE a=release"

Adding DONTBUILD should do the trick to prevent this misuse of resources.

This sounds like a good intern bug :)

[1] http://hg.mozilla.org/releases/mozilla-1.9.2/rev/0219ac257e3c
[2] https://tbpl.mozilla.org/?tree=Firefox3.6&rev=0219ac257e3c

Comment 1

[Armen [:armenzg]]

For the record this does not seem to be happening for Mozilla-Beta.

https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=5b94a143a4ec
https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=f2a16e2a67ca

Comment 2

[Justin Wood (:Callek)]

(In reply to Armen Zambrano G. [:armenzg] - Release Engineer from comment #1)
> For the record this does not seem to be happening for Mozilla-Beta.
> 
> https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=5b94a143a4ec
> https://tbpl.mozilla.org/?tree=Mozilla-Beta&rev=f2a16e2a67ca

Thats because on mozilla-beta we don't do a change on |default| we relbranch and do our (fake) version update on that. 3.6.x has the unique (now) situation of needing to change the default version #

Comment 3

[[e-mail] (:bhearsum)]

We should just add DONTBUILD to the commit message.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: add DONTBUILD to tag and bump commits

I don't think there's any reason that these should ever be non-DONTBUILD.

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 596557 [details] [diff] [review]
add DONTBUILD to tag and bump commits

The logic looks good, but the patch needs to be refreshed. The current one failed to apply.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: unbitrotted

I also removed an unused import.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 596986 [details] [diff] [review]
unbitrotted

Landed: changeset:   2234:f16684d20b34