720764 - Show toast alert for opening a new tab in the background from the Awesomescreen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently when you open a new tab in the background from the Awesomescreen there is no toast alert notification akin to how you see it through traditional tab opening means in web content.

--
Samsung Galaxy Nexus (Android 4.0.3)
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120124 Firefox/12.0a1 Fennec/12.0a1

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Show toast notification when opening link in a new tab in awesomebar

Comment 2

[Aaron Train [:aaronmt]]

Isn't there already a property or string entity in the toast for when you open a new tab via context menu in web-content: 'New tab opened'?

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Aaron Train [:aaronmt] from comment #2)
> Isn't there already a property or string entity in the toast for when you
> open a new tab via context menu in web-content: 'New tab opened'?

No, the existing one is on the gecko side.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Technically, I don't see the tab being opened in the background. It's just behind the Awesomebar. It still becomes the selected tab. Is this the intent of the feature?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 593119 [details] [diff] [review]
Show toast notification when opening link in a new tab in awesomebar

Since this is not truly a background tab, we can't handle this in Gecko, where I hoped to put the code. We really do need to do this in Java.

Comment 6

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/d170e6c4ce3e

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 593119 [details] [diff] [review]
Show toast notification when opening link in a new tab in awesomebar

Important polish fix. Feedback when opening a URL in a new tab from awesome screen. Non-risk. Adds one string though.

Comment 8

[Lucas Rocha (:lucasr)]

Comment on attachment 593119 [details] [diff] [review]
Show toast notification when opening link in a new tab in awesomebar

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d170e6c4ce3e

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 593119 [details] [diff] [review]
Show toast notification when opening link in a new tab in awesomebar

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f88bdcf5fbf

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5afb170dafc8

Comment 13

[Axel Hecht [:Pike]]

This broke string freeze, just like so. Lucas, fill out the form when you request approval. Alex, if someone doesn't fill out the form, just don't grant approval, please?

Comment 14

[Camelia Urian]

Nightly 13.0a1 (2012-02-06)
Aurora 12.0a2 (2012-02-07)
Beta 11.0 (20120206202409 - http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116)
Device: Samsung Google Nexus S - Android 2.3.6