Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Screen orientation API reading and event implementation in Android

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla14
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 591218 [details] [diff] [review]
Patch
Attachment #591218 - Flags: review?(doug.turner)

Comment 1

6 years ago
Comment on attachment 591218 [details] [diff] [review]
Patch

Review of attachment 591218 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoScreenOrientationListener.java
@@ +106,5 @@
> +      mOrientation = eScreenOrientation_LandscapeSecondary;
> +    } else if (rotation == Surface.ROTATION_90) {
> +      mOrientation = eScreenOrientation_LandscapePrimary;
> +    } else {
> +      Log.e("GeckoScreenOrientationListener", "Unexpected value received! (" + rotation + ")");

i think you just should return early
Attachment #591218 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 2

6 years ago
Comment on attachment 591218 [details] [diff] [review]
Patch

Pushed with the early return.
Attachment #591218 - Flags: checkin+
(Assignee)

Updated

6 years ago
Flags: in-testsuite?
Target Milestone: --- → mozilla13

Comment 3

6 years ago
Backed out of inbound for build failures on all platforms:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=4a763183482f

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c7eaaeec91
Target Milestone: mozilla13 → ---

Comment 4

6 years ago
Relanded, but the push had to be backed out again for bustage:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=1ca8d5a931ac

https://hg.mozilla.org/integration/mozilla-inbound/rev/33ffd55f2dfe

Please can this/the rest of the push be run on try before landing a third time :-)
https://hg.mozilla.org/mozilla-central/rev/aa978ffa44bc so it must have been :)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
I backed this out along with all the other patches in the initial push. Something in the push regressed Ts on Android by 20% and I don't know which patch is to blame:

https://hg.mozilla.org/mozilla-central/rev/e94edfdb1f5b

Regression Ts increase 20.6% on Android 2.2 Mozilla-Inbound
--------------------------------------------------------------
    Previous: avg 2653.656 stddev 87.856 of 30 runs up to revision 1239bd0779a6
    New     : avg 3201.178 stddev 110.202 of 5 runs since revision 0d61a0d8dba4
    Change  : +547.522 (20.6% / z=6.232)
    Graph   : http://mzl.la/zD3EWy
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

5 years ago
Depends on: 737392
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7bcf75d570a8
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.