Last Comment Bug 720891 - GC: de-specialize TypeObject marking
: GC: de-specialize TypeObject marking
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla12
Assigned To: Terrence Cole [:terrence]
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 720522
  Show dependency treegraph
Reported: 2012-01-24 16:30 PST by Terrence Cole [:terrence]
Modified: 2012-01-25 07:08 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v0 (2.49 KB, patch)
2012-01-24 16:30 PST, Terrence Cole [:terrence]
bhackett1024: review+
Details | Diff | Splinter Review

Description User image Terrence Cole [:terrence] 2012-01-24 16:30:38 PST
Created attachment 591317 [details] [diff] [review]

This is a minor speedup at best and is a confusing twist to a tracer that is confusingly twisted already.
Comment 1 User image Bill McCloskey (:billm) 2012-01-24 18:52:05 PST
Comment on attachment 591317 [details] [diff] [review]

Brian is probably a better reviewer for this.

Brian, we want to do this so that we can share all the code for the mark functions via macros. The fact that MarkTypeObject is special makes this a problem. I remember you saying that this optimization wasn't very important, so I'm hoping we can remove it.
Comment 2 User image Brian Hackett (:bhackett) 2012-01-24 18:56:45 PST
Comment on attachment 591317 [details] [diff] [review]

Review of attachment 591317 [details] [diff] [review]:

Huh, I thought this had always been removed.  I added that stuff mainly to avoid needing to call js_TraceScript (I think) but that justification no longer applies.
Comment 3 User image Terrence Cole [:terrence] 2012-01-24 19:09:01 PST
Comment 4 User image :Ms2ger (⌚ UTC+1/+2) 2012-01-25 07:08:02 PST

Note You need to log in before you can comment on or make changes to this bug.