GC: de-specialize TypeObject marking

RESOLVED FIXED in mozilla12

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 591317 [details] [diff] [review]
v0

This is a minor speedup at best and is a confusing twist to a tracer that is confusingly twisted already.
Attachment #591317 - Flags: review?(wmccloskey)
Comment on attachment 591317 [details] [diff] [review]
v0

Brian is probably a better reviewer for this.

Brian, we want to do this so that we can share all the code for the mark functions via macros. The fact that MarkTypeObject is special makes this a problem. I remember you saying that this optimization wasn't very important, so I'm hoping we can remove it.
Attachment #591317 - Flags: review?(wmccloskey) → review?(bhackett1024)
Comment on attachment 591317 [details] [diff] [review]
v0

Review of attachment 591317 [details] [diff] [review]:
-----------------------------------------------------------------

Huh, I thought this had always been removed.  I added that stuff mainly to avoid needing to call js_TraceScript (I think) but that justification no longer applies.
Attachment #591317 - Flags: review?(bhackett1024) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbb9dbfe659b
https://hg.mozilla.org/mozilla-central/rev/bbb9dbfe659b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.