Closed
Bug 720891
Opened 14 years ago
Closed 14 years ago
GC: de-specialize TypeObject marking
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
|
2.49 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
This is a minor speedup at best and is a confusing twist to a tracer that is confusingly twisted already.
Attachment #591317 -
Flags: review?(wmccloskey)
Comment on attachment 591317 [details] [diff] [review]
v0
Brian is probably a better reviewer for this.
Brian, we want to do this so that we can share all the code for the mark functions via macros. The fact that MarkTypeObject is special makes this a problem. I remember you saying that this optimization wasn't very important, so I'm hoping we can remove it.
Attachment #591317 -
Flags: review?(wmccloskey) → review?(bhackett1024)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 591317 [details] [diff] [review]
v0
Review of attachment 591317 [details] [diff] [review]:
-----------------------------------------------------------------
Huh, I thought this had always been removed. I added that stuff mainly to avoid needing to call js_TraceScript (I think) but that justification no longer applies.
Attachment #591317 -
Flags: review?(bhackett1024) → review+
|
Assignee | |
Comment 3•14 years ago
|
||
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•