720932 - Clean up default search engine code

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

+++ This bug was initially created as a clone of Bug #718296 +++

When the user types in the location bar and just presses Go/Search without explicitly choosing a search engine, we use Gecko's "third-party fixup" logic to decide whether to treat the input as a URI or do a search with the default search engine.  Since this logic is now handled entirely in Gecko, the Java front-end does not need to know about it.  This patch eliminates the fake "__default__" search engine parameter, and instead just passes the plain user input to Gecko.

With this patch, the front-end no longer uses nsIURIFixup.FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP directly.  This matches desktop Firefox (which does not use this feature at all) and XUL Fennec (which uses it only for URLs to display, not for the actual URL to load):
https://mxr.mozilla.org/mozilla-central/ident?i=FIXUP_FLAG_ALLOW_KEYWORD_LOOKUP

Comment 1

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d711befe9037

Comment 2

[Matt Brubeck (:mbrubeck)]

Comment on attachment 591362 [details] [diff] [review]
patch

[Approval Request Comment]
Low-risk Android-only code cleanup.  Not a blocker for shipping, but wanted on Aurora and Beta so any dependent patches can land.

Comment 3

[Alex Keybl [:akeybl]]

Comment on attachment 591362 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/02fa348742c8

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c0de524a4cca
https://hg.mozilla.org/releases/mozilla-beta/rev/bb736ca962ff

Comment 6

[Cristian Nicolae (:xti)]

Verified fixed on:

Firefox 13.0a1 (2012-02-07)
20120207031136
http://hg.mozilla.org/mozilla-central/rev/b077059c575a
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 12.0a2 (2012-02-06)
20120206042011
http://hg.mozilla.org/releases/mozilla-aurora/rev/9fb0c06ceb49
Device: HTC Desire Z
OS: Android 2.3.3

Firefox 11.0
20120206202409
http://hg.mozilla.org/releases/mozilla-beta/rev/1c0aba74d116
Device: HTC Desire Z
OS: Android 2.3.3