Closed Bug 720955 Opened 12 years ago Closed 12 years ago

pyxpt: Report IIDs when they differ

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla12

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(
URL
)

Details

Attachments

(1 file)

(Av1) xpt.py: Report IIDs when they differ [Checked in: Comment 3]
2.06 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Code is
{
1210                         else:
1211                             # Same name, different IIDs, raise an exception
1212                             raise DataError, \
1213                                   "Typelibs contain definitions of interface %s"\
1214                                   " with different IIDs!" % i.name
1215                 elif i.iid == j.iid and i.iid != Interface.UNRESOLVED_IID:
1216                     # Same IID, different names, raise an exception
1217                     raise DataError, \
1218                           "Typelibs contain definitions of interface %s"\
1219                           " with different names (%s vs. %s)!" %  \
1220                           (i.iid, i.name, j.name)
}

1) Line 1213:
IIDs should be reported, as names are at line 1218.

2) Both:
Could it be possible to report the involved xpts too?
With their timestamp?
This should fix part 1.
(Untested.)
Attachment #591389 - Flags: review?
Attachment #591389 - Flags: review? → review?(mh+mozilla)
Comment on attachment 591389 [details] [diff] [review]
(Av1) xpt.py: Report IIDs when they differ
[Checked in: Comment 3]

Ted knowns the code better than I do.
Attachment #591389 - Flags: review?(mh+mozilla) → review?(ted.mielczarek)
Attachment #591389 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 591389 [details] [diff] [review]
(Av1) xpt.py: Report IIDs when they differ
[Checked in: Comment 3]

https://hg.mozilla.org/mozilla-central/rev/03ae304e45af
Attachment #591389 - Attachment description: (Av1) xpt.py: Report IIDs when they differ → (Av1) xpt.py: Report IIDs when they differ [Checked in: Comment 3]
Assignee: nobody → sgautherie.bz
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Summary: pyxpt: Give more details about interfaces with different IID/names → pyxpt: Report IIDs when they differ
Target Milestone: --- → mozilla12
(In reply to Serge Gautherie (:sgautherie) from comment #0)
> 2) Both:
> Could it be possible to report the involved xpts too?
> With their timestamp?

Is it worth that I filed another bug about part 2, or would that be wontfix_able/ed?
Seems totally reasonable to have the xpt filenames in the error messages.
V.Fixed, per bug 720952 comment 6.
Status: RESOLVED → VERIFIED
(In reply to Ted Mielczarek [:ted, :luser] from comment #5)
> Seems totally reasonable to have the xpt filenames in the error messages.

Bug 721065
Blocks: 721065
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.