Closed
Bug 720955
Opened 13 years ago
Closed 13 years ago
pyxpt: Report IIDs when they differ
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla12
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
Attachments
(1 file)
|
2.06 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Code is
{
1210 else:
1211 # Same name, different IIDs, raise an exception
1212 raise DataError, \
1213 "Typelibs contain definitions of interface %s"\
1214 " with different IIDs!" % i.name
1215 elif i.iid == j.iid and i.iid != Interface.UNRESOLVED_IID:
1216 # Same IID, different names, raise an exception
1217 raise DataError, \
1218 "Typelibs contain definitions of interface %s"\
1219 " with different names (%s vs. %s)!" % \
1220 (i.iid, i.name, j.name)
}
1) Line 1213:
IIDs should be reported, as names are at line 1218.
2) Both:
Could it be possible to report the involved xpts too?
With their timestamp?
|
Assignee | |
Comment 1•13 years ago
|
||
This should fix part 1.
(Untested.)
Attachment #591389 -
Flags: review?
|
|
Assignee | |
Updated•13 years ago
|
Attachment #591389 -
Flags: review? → review?(mh+mozilla)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 591389 [details] [diff] [review]
(Av1) xpt.py: Report IIDs when they differ
[Checked in: Comment 3]
Ted knowns the code better than I do.
Attachment #591389 -
Flags: review?(mh+mozilla) → review?(ted.mielczarek)
|
||
Updated•13 years ago
|
Attachment #591389 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 591389 [details] [diff] [review]
(Av1) xpt.py: Report IIDs when they differ
[Checked in: Comment 3]
https://hg.mozilla.org/mozilla-central/rev/03ae304e45af
Attachment #591389 -
Attachment description: (Av1) xpt.py: Report IIDs when they differ → (Av1) xpt.py: Report IIDs when they differ
[Checked in: Comment 3]
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → sgautherie.bz
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Summary: pyxpt: Give more details about interfaces with different IID/names → pyxpt: Report IIDs when they differ
Target Milestone: --- → mozilla12
|
|
Assignee | |
Comment 4•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #0)
> 2) Both:
> Could it be possible to report the involved xpts too?
> With their timestamp?
Is it worth that I filed another bug about part 2, or would that be wontfix_able/ed?
|
|
||
Comment 5•13 years ago
|
||
Seems totally reasonable to have the xpt filenames in the error messages.
|
|
Assignee | |
Comment 7•13 years ago
|
||
(In reply to Ted Mielczarek [:ted, :luser] from comment #5)
> Seems totally reasonable to have the xpt filenames in the error messages.
Bug 721065
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•