720955 - pyxpt: Report IIDs when they differ

Status: VERIFIED FIXED

(Firefox Build System :: General, enhancement)

Description

[Serge Gautherie (:sgautherie)]

Code is
{
1210                         else:
1211                             # Same name, different IIDs, raise an exception
1212                             raise DataError, \
1213                                   "Typelibs contain definitions of interface %s"\
1214                                   " with different IIDs!" % i.name
1215                 elif i.iid == j.iid and i.iid != Interface.UNRESOLVED_IID:
1216                     # Same IID, different names, raise an exception
1217                     raise DataError, \
1218                           "Typelibs contain definitions of interface %s"\
1219                           " with different names (%s vs. %s)!" %  \
1220                           (i.iid, i.name, j.name)
}

1) Line 1213:
IIDs should be reported, as names are at line 1218.

2) Both:
Could it be possible to report the involved xpts too?
With their timestamp?

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) xpt.py: Report IIDs when they differ [Checked in: Comment 3]

This should fix part 1.
(Untested.)

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 591389 [details] [diff] [review]
(Av1) xpt.py: Report IIDs when they differ
[Checked in: Comment 3]

Ted knowns the code better than I do.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 591389 [details] [diff] [review]
(Av1) xpt.py: Report IIDs when they differ
[Checked in: Comment 3]

https://hg.mozilla.org/mozilla-central/rev/03ae304e45af

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #0)
> 2) Both:
> Could it be possible to report the involved xpts too?
> With their timestamp?

Is it worth that I filed another bug about part 2, or would that be wontfix_able/ed?

Comment 5

[(not currently active) Ted Mielczarek]

Seems totally reasonable to have the xpt filenames in the error messages.

Comment 6

[Serge Gautherie (:sgautherie)]

V.Fixed, per bug 720952 comment 6.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to Ted Mielczarek [:ted, :luser] from comment #5)
> Seems totally reasonable to have the xpt filenames in the error messages.

Bug 721065