720982 - Duplicated code: nsHTMLEditor::CreateBRImpl / nsPlaintextEditor::CreateBRImpl

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

As in 2001: bug 68747.

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Diff

Difference between the implementations.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: InsertBR

Two for the price of one

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Diff b

Comment 4

[(no longer active)]

Comment on attachment 591411 [details] [diff] [review]
Patch v1

Review of attachment 591411 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the below.

::: editor/libeditor/html/nsHTMLEditor.cpp
@@ +1386,5 @@
>                                           nsCOMPtr<nsIDOMNode> *outBRNode, 
>                                           EDirection aSelect)
>  {
> +  return nsPlaintextEditor::CreateBRImpl(aInOutParent, aInOutOffset, outBRNode,
> +                                         aSelect);

Why not just remove this function altogether?  :-)

Comment 5

[(no longer active)]

Comment on attachment 591413 [details] [diff] [review]
Part b: InsertBR

Review of attachment 591413 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditor.cpp
@@ +1399,5 @@
>  }
>  
>  NS_IMETHODIMP nsHTMLEditor::InsertBR(nsCOMPtr<nsIDOMNode> *outBRNode)
>  {
> +  return nsPlaintextEditor::InsertBR(outBRNode);

Again, please just remove this method!

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/d2fb1257034b
https://hg.mozilla.org/mozilla-central/rev/1e927f5cc830