721079 - Calling preventDefault on the first touchmove event prevents panning, but not quickly enough

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

See mbrubeck's test page:

http://limpet.net/w3/touchevents/preventDefault.html

panning on the prevent move box should not allow panning at all, but I believe that it will pan for a short distance and then stop. We have a bunch of timeout code designed to handle just this. Either the timeout is not long enough, or the code is not working correctly. I'm guessing its the later.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch 1/2

Two parts to fix this. Luckily, they're small fixes now! I don't think I handled notifying correctly. Smaug, this works, but I'm not sure its correct. This ok?

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch 2/2

This was fallout from bad unbitrotting by me :( I lost some of the fixes for being notified if we had listeners in java. This restores them.

Comment 3

[Wesley Johnston (:wesj)]

Part 2 inbound - http://hg.mozilla.org/integration/mozilla-inbound/rev/2fdade6a7582

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

...assuming whoever listens for that notification does the right thing.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2fdade6a7582

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 592928 [details] [diff] [review]
Patch 1/2

Regression caused by (bug #): 603008 multitouch
User impact if declined: Errors with multitouch events firing incorrectly
Testing completed (on m-c, etc.): landed on mc 1/2/2012
Risk to taking this patch (and alternatives if risky): Low risk. Should only affect builds with touch events enabled (i.e. mobile and b2g.

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 592930 [details] [diff] [review]
Patch 2/2

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Regression caused by (bug #): 603008 multitouch
User impact if declined: Errors with multitouch events firing incorrectly
Testing completed (on m-c, etc.): landed on mc 1/2/2012
Risk to taking this patch (and alternatives if risky): Low risk. Should only affect builds with touch events enabled (i.e. mobile and b2g.

Comment 8

[Wesley Johnston (:wesj)]

Whoops. Forgot to list part 1:
http://hg.mozilla.org/mozilla-central/rev/69ca6e6c57ea

Comment 9

[Wesley Johnston (:wesj)]

Comment on attachment 592930 [details] [diff] [review]
Patch 2/2

This is already on Aurora.

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 592928 [details] [diff] [review]
Patch 1/2

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 592930 [details] [diff] [review]
Patch 2/2

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

part 1
https://hg.mozilla.org/releases/mozilla-aurora/rev/120652cab075

part 2 is already on aurora

Comment 13

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/releases/mozilla-beta/rev/07a6e25f6362
https://hg.mozilla.org/releases/mozilla-beta/rev/6e92cda6055a