721104 - Cache the empty awesomebar search (and others?) in memory at least

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Wesley Johnston (:wesj)]

In XUL Fennec we used to cache the "" awesomebar search. We actually cached it on disk so that we could quickly load the results without waiting for places. We could do something similar in Native Fennec. Since we're trying to avoid file i/o, I'm not sure it would be a huge help to cache on disk (although we could try that, and open the file in a background thread on startup?).

But we could at least cache the Cursor the first time we do the query. Subsequently showing the awesomebar should show the cached cursor results quickly, and then do a new query in the background.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Cache AwesomeBar's 'Top Sites' query for a certain time

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 593104 [details] [diff] [review]
Cache AwesomeBar's 'Top Sites' query for a certain time

I think we should skip this until we see if bug 725914 speeds things up enough. I do not like caching cursors. Danger, danger!

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 593104 [details] [diff] [review]
> Cache AwesomeBar's 'Top Sites' query for a certain time
> 
> I think we should skip this until we see if bug 725914 speeds things up
> enough. I do not like caching cursors. Danger, danger!

Fair enough :-)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

File a new bug if the latest DB, ViewObject and async favicon changes are not enough. Cache cursors is too risky IMO.