Last Comment Bug 721136 - transform property serialization doesn't normalize case
: transform property serialization doesn't normalize case
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: CSS Object Model (show other bugs)
: Trunk
: x86 Linux
: -- minor (vote)
: mozilla13
Assigned To: :Aryeh Gregor (working until September 2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-25 11:23 PST by :Aryeh Gregor (working until September 2)
Modified: 2012-02-16 03:02 PST (History)
2 users (show)
dao+bmo: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (4.87 KB, patch)
2012-02-13 12:41 PST, :Aryeh Gregor (working until September 2)
dbaron: review+
Details | Diff | Splinter Review
Patch v2 (4.88 KB, patch)
2012-02-13 13:23 PST, :Aryeh Gregor (working until September 2)
ayg: review+
Details | Diff | Splinter Review

Description :Aryeh Gregor (working until September 2) 2012-01-25 11:23:40 PST
data:text/html,<!DOCTYPE html>
<script>
document.head.style.MozTransform = 'RotatE( 3rAd )scalex(2) translateX(10%)';
document.documentElement.textContent = 
document.head.style.MozTransform
</script>

Results (adjusted for prefixes):

IE9, Chrome 17 dev: rotate(3rad) scaleX(2) translateX(10%)
Firefox 12.0a1: RotatE(3rad) scalex(2) translateX(10%)
Opera Next 12.00 alpha: rotate(171.89deg) scaleX(2) translateX(10%)

Behavior here is not currently specified, and I filed a spec bug on it:

https://www.w3.org/Bugs/Public/show_bug.cgi?id=15710

I recommended the IE/Chrome behavior, since it makes the most sense.  Either the input should be returned as-is with no normalization, or everything should be normalized, including function names' case.  But all browsers but Opera agree units shouldn't be mangled.
Comment 1 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-01-25 11:45:33 PST
We'd probably want to fix this in either CSSParserImpl::ParseFunction or CSSParserImpl::ParseSingleTransform.
Comment 2 :Aryeh Gregor (working until September 2) 2012-02-13 12:41:07 PST
Created attachment 596754 [details] [diff] [review]
Patch v1

Dunno if this is the right way to do it, but it works for me.
Comment 3 Mozilla RelEng Bot 2012-02-13 12:45:00 PST
Autoland Patchset:
	Patches: 596754
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=abb8726f04a7
Try run started, revision abb8726f04a7. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=abb8726f04a7
Comment 4 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2012-02-13 13:02:27 PST
Comment on attachment 596754 [details] [diff] [review]
Patch v1

>+    default:
>+      ;

Make this "break;" instead of ";".

r=dbaron with that
Comment 5 :Aryeh Gregor (working until September 2) 2012-02-13 13:23:38 PST
Created attachment 596775 [details] [diff] [review]
Patch v2
Comment 6 Mozilla RelEng Bot 2012-02-13 22:16:00 PST
Try run for abb8726f04a7 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=abb8726f04a7
Results (out of 211 total builds):
    exception: 2
    success: 175
    warnings: 20
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-abb8726f04a7
Comment 8 Marco Bonardo [::mak] 2012-02-16 03:02:58 PST
https://hg.mozilla.org/mozilla-central/rev/7c1f492fc1b1

Note You need to log in before you can comment on or make changes to this bug.