transform property serialization doesn't normalize case

RESOLVED FIXED in mozilla13

Status

()

Core
DOM: CSS Object Model
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ayg, Assigned: ayg)

Tracking

Trunk
mozilla13
x86
Linux
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

data:text/html,<!DOCTYPE html>
<script>
document.head.style.MozTransform = 'RotatE( 3rAd )scalex(2) translateX(10%)';
document.documentElement.textContent = 
document.head.style.MozTransform
</script>

Results (adjusted for prefixes):

IE9, Chrome 17 dev: rotate(3rad) scaleX(2) translateX(10%)
Firefox 12.0a1: RotatE(3rad) scalex(2) translateX(10%)
Opera Next 12.00 alpha: rotate(171.89deg) scaleX(2) translateX(10%)

Behavior here is not currently specified, and I filed a spec bug on it:

https://www.w3.org/Bugs/Public/show_bug.cgi?id=15710

I recommended the IE/Chrome behavior, since it makes the most sense.  Either the input should be returned as-is with no normalization, or everything should be normalized, including function names' case.  But all browsers but Opera agree units shouldn't be mangled.
We'd probably want to fix this in either CSSParserImpl::ParseFunction or CSSParserImpl::ParseSingleTransform.
Created attachment 596754 [details] [diff] [review]
Patch v1

Dunno if this is the right way to do it, but it works for me.
Assignee: nobody → ayg
Attachment #596754 - Flags: review?(dbaron)
Whiteboard: [autoland]

Updated

6 years ago
Whiteboard: [autoland] → [autoland-in-queue]

Comment 3

6 years ago
Autoland Patchset:
	Patches: 596754
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=abb8726f04a7
Try run started, revision abb8726f04a7. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=abb8726f04a7
Comment on attachment 596754 [details] [diff] [review]
Patch v1

>+    default:
>+      ;

Make this "break;" instead of ";".

r=dbaron with that
Attachment #596754 - Flags: review?(dbaron) → review+
Created attachment 596775 [details] [diff] [review]
Patch v2
Attachment #596754 - Attachment is obsolete: true
Attachment #596775 - Flags: review+

Comment 6

6 years ago
Try run for abb8726f04a7 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=abb8726f04a7
Results (out of 211 total builds):
    exception: 2
    success: 175
    warnings: 20
    failure: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-abb8726f04a7

Updated

6 years ago
Whiteboard: [autoland-in-queue]
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/7c1f492fc1b1
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/7c1f492fc1b1
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.